Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters By Main Property Zones #1075

Conversation

DonovanAndrews300
Copy link
Contributor

@DonovanAndrews300 DonovanAndrews300 commented Jan 10, 2025

Description
This was previously released, but only property zone filtering was applied. This PR updates the zoning filter dropdown to display only main zones as filter options while automatically applying the corresponding subzones. I created a new branch to implement these changes as it seemed cleaner. See issue #1058.

Screencast
Screencast from 01-10-2025 09:32:52 AM.webm

Steps to Test

Navigate to the property map.
Open the filter pane.
Check the Zoning filters to verify that only main zones are listed as filter options.
Confirm that all main zones are correctly listed.
Ensure that selecting a main zone applies all relevant subzones.
While focused on any filter dropdown, type to search for specific options.
All filters should be able to be applied and removed.

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 8:08pm

@DonovanAndrews300 DonovanAndrews300 changed the title filters only by main property zones Filters By Main Property Zones Jan 10, 2025
@CodeWritingCow CodeWritingCow changed the base branch from main to staging January 11, 2025 16:26
@CodeWritingCow
Copy link
Collaborator

Hi @DonovanAndrews300 the zoning and priority filters are working correctly. Thank you!

Can you add RSA to the subZoning? Once that's added, I'll approve and merge this PR.

(By the way, I've changed this PR's base branch from main to staging. I'll update this repo's contributors guide to let folks know that generally they should submit PRs against staging branch.)

Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DonovanAndrews300, I tested the PR again. It looks good to go. Thank you for working with me on this!

@CodeWritingCow CodeWritingCow removed the request for review from zigouras January 11, 2025 20:30
@CodeWritingCow CodeWritingCow merged commit 01c2722 into CodeForPhilly:staging Jan 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants