Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-bootstrap and bootstrap to dependencies #31

Merged
merged 1 commit into from
May 5, 2023

Conversation

travissouthard
Copy link
Collaborator

@travissouthard travissouthard commented May 5, 2023

Overview

Adds react-bootstrap and bootstrap to our dependencies.

Closes #26

Testing instructions

  • In this branch, apply the following temporary changes:
diff --git a/src/app/src/App.tsx b/src/app/src/App.tsx
index e5e04bf..1358f17 100644
--- a/src/app/src/App.tsx
+++ b/src/app/src/App.tsx
@@ -1,3 +1,5 @@
+import Alert from 'react-bootstrap/Alert';
+
 import './App.css'
 import Map from './Map/Map'
 
@@ -7,6 +9,7 @@ function App() {
 
   return (
     <div>
+      <Alert variant={'warning'}>Bootstrap is working</Alert>
       <div className="title">THIRD PLACES PROJECT</div>
         <Map/>
     </div>
  • Run docker-compose up --build, navigate to http://localhost:4321/ and ensure:
    • No warnings appear in the console or in the react logs in the terminal
    • The homepage opens correctly
    • You can see the warning text on the homepage

Checklist before merge

  • Update the CHANGELOG.md
  • Rebase your changes from whatever branch you're merging to

Copy link
Collaborator

@mdarkcity mdarkcity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does appear!

Took me a while to realize I had to import the bootstrap stylesheet to get the Alert styling (in App.tsx or main.tsx). Of course, we can override with our own styling in App.css / index.css.

@sodamodo sodamodo merged commit 673a995 into develop May 5, 2023
@themightychris themightychris mentioned this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add react-bootstrap to project
3 participants