-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geoJSON layer: handle hover, improve click handling, use icons #42
Open
qualitymanifest
wants to merge
13
commits into
CodeForPittsburgh:fix-map
Choose a base branch
from
qualitymanifest:fix-map
base: fix-map
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
geoJSON layer: handle hover, improve click handling, use icons #42
qualitymanifest
wants to merge
13
commits into
CodeForPittsburgh:fix-map
from
qualitymanifest:fix-map
Commits on Jan 29, 2020
-
Change cursor type on point hover
- Throttled the hover event so that it doesn't blow up slower computers - Changed click radius for computers. Once hovering was implemented it was clear that the click radius was way too wide for precise pointers. User agent sniffing might not be a guarantee but it is probably the best option, short of waiting for a touch event and changing the click radius.
Configuration menu - View commit details
-
Copy full SHA for 01be576 - Browse repository at this point
Copy the full SHA 01be576View commit details -
Remove coordinate correction hack
Wanted to remove this now so that it doesn't get forgotten about. Roughly half of the points will appear in Antarctica until the coordinates are corrected in the database.
Configuration menu - View commit details
-
Copy full SHA for ceba4ab - Browse repository at this point
Copy the full SHA ceba4abView commit details -
Configuration menu - View commit details
-
Copy full SHA for acfb7a9 - Browse repository at this point
Copy the full SHA acfb7a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6a4d68 - Browse repository at this point
Copy the full SHA d6a4d68View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0b39b1 - Browse repository at this point
Copy the full SHA b0b39b1View commit details
Commits on Jan 30, 2020
-
Use images instead of built-in Mapbox icons
Obviously the images need to be changed and expanded upon. I grabbed these (free, no-attribution) icons from iconfinder.com just to use them as an example. Relevant issue CodeForPittsburgh#36 here for icon status, and issue CodeForPittsburgh#19 at food-access-map-data for info on location type attributes
Configuration menu - View commit details
-
Copy full SHA for 4a4c5ab - Browse repository at this point
Copy the full SHA 4a4c5abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 002fa4e - Browse repository at this point
Copy the full SHA 002fa4eView commit details -
I had previously assumed that the other site data was passed into foodSiteDetail, however after looking it is clear that it is intended to fetch that from the server. No point in processing it into an object then.
Configuration menu - View commit details
-
Copy full SHA for 8c830f6 - Browse repository at this point
Copy the full SHA 8c830f6View commit details -
This fixes mapbox error 'Error removing layer of undefined' when navigating away from the map component I thought I had updated react-map-gl to the newest already but apparently not!
Configuration menu - View commit details
-
Copy full SHA for dafa883 - Browse repository at this point
Copy the full SHA dafa883View commit details
Commits on Jan 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d3d4821 - Browse repository at this point
Copy the full SHA d3d4821View commit details
Commits on Feb 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 333ec22 - Browse repository at this point
Copy the full SHA 333ec22View commit details
Commits on Feb 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f0946ff - Browse repository at this point
Copy the full SHA f0946ffView commit details
Commits on Feb 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a054aaa - Browse repository at this point
Copy the full SHA a054aaaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.