Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoJSON layer: handle hover, improve click handling, use icons #42

Open
wants to merge 13 commits into
base: fix-map
Choose a base branch
from

Commits on Jan 29, 2020

  1. Change cursor type on point hover

    - Throttled the hover event so that it doesn't blow up slower computers
    - Changed click radius for computers. Once hovering was implemented it was clear that the click radius was way too wide for precise pointers. User agent sniffing might not be a guarantee but it is probably the best option, short of waiting for a touch event and changing the click radius.
    qualitymanifest committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    01be576 View commit details
    Browse the repository at this point in the history
  2. Remove coordinate correction hack

    Wanted to remove this now so that it doesn't get forgotten about. Roughly half of the points will appear in Antarctica until the coordinates are corrected in the database.
    qualitymanifest committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    ceba4ab View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    acfb7a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d6a4d68 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b0b39b1 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. Use images instead of built-in Mapbox icons

    Obviously the images need to be changed and expanded upon. I grabbed these (free, no-attribution) icons from iconfinder.com just to use them as an example.
    
    Relevant issue CodeForPittsburgh#36 here for icon status, and issue CodeForPittsburgh#19 at food-access-map-data for info on location type attributes
    qualitymanifest committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    4a4c5ab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    002fa4e View commit details
    Browse the repository at this point in the history
  3. Remove siteLookup

    I had previously assumed that the other site data was passed into foodSiteDetail, however after looking it is clear that it is intended to fetch that from the server. No point in processing it into an object then.
    qualitymanifest committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    8c830f6 View commit details
    Browse the repository at this point in the history
  4. Update react-map-gl

    This fixes mapbox error 'Error removing layer of undefined' when navigating away from the map component
    
    I thought I had updated react-map-gl to the newest already but apparently not!
    qualitymanifest committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    dafa883 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. Configuration menu
    Copy the full SHA
    d3d4821 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2020

  1. Configuration menu
    Copy the full SHA
    333ec22 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Configuration menu
    Copy the full SHA
    f0946ff View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Configuration menu
    Copy the full SHA
    a054aaa View commit details
    Browse the repository at this point in the history