Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config system and customize command handling #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Andre601
Copy link
Collaborator

The Slash command handling has been tweaked to a own system to allow role-checking instead of permission checks.

Additionally have context menu commands been added to allow the accepting/denial of applications within the request-access channel.

Also change command system to custom implementation for role support.
@Andre601 Andre601 requested review from tr7zw and sgdc3 April 27, 2024 22:43
Copy link
Member

@gmitch215 gmitch215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno if I have authority anyways...

src/main/java/io/codemc/bot/listeners/ModalListener.java Outdated Show resolved Hide resolved
src/main/java/io/codemc/bot/menu/ApplicationMenu.java Outdated Show resolved Hide resolved
src/main/java/io/codemc/bot/menu/ApplicationMenu.java Outdated Show resolved Hide resolved
src/main/java/io/codemc/bot/commands/BotCommand.java Outdated Show resolved Hide resolved
src/main/java/io/codemc/bot/commands/BotCommand.java Outdated Show resolved Hide resolved
src/main/java/io/codemc/bot/utils/Constants.java Outdated Show resolved Hide resolved
Copy link
Member

@gmitch215 gmitch215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, few more cleanup things and one question

gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
src/main/java/io/codemc/bot/menu/ApplicationMenu.java Outdated Show resolved Hide resolved
src/main/resources/config.json Outdated Show resolved Hide resolved
gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
@sgdc3 sgdc3 mentioned this pull request Apr 29, 2024
@sgdc3 sgdc3 linked an issue Apr 29, 2024 that may be closed by this pull request
@Andre601 Andre601 requested review from sgdc3 and gmitch215 May 16, 2024 12:49
build.gradle Show resolved Hide resolved
Copy link
Member

@gmitch215 gmitch215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing things added in #5, LGTM

@Andre601 Andre601 changed the title Create Context Menu Actions and customize command handling Add config system and customize command handling Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Reviewed
Development

Successfully merging this pull request may close these issues.

Configuration file
3 participants