Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing button styling #225

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Fixing button styling #225

merged 1 commit into from
Sep 14, 2024

Conversation

avenmia
Copy link
Collaborator

@avenmia avenmia commented Sep 6, 2024

Button styling should be more consistent, less duplication, and disabled buttons will display as disabled now.

@avenmia avenmia requested a review from a team as a code owner September 6, 2024 03:03
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hierr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 3:04am

@Lawrence-Kwok
Copy link

In terms of the back and next buttons, the functionality works and displays the appropriate disabled symbol on hover if a choice hasn't been made. However in select few instances, the next button is disabled even when it should be valid to proceed:

(1) Clicking Back on the First Demographic Question (How To Replicate):

  • Click either Yes/No Radio Button Option
  • Click on Back Option (will stay on the same question)
  • Attempt to Click on the Next Button (upon hovering it will appear as disabled)

1st Demographic Question

(2) Clicking on Entries with Blank Insert Text Boxes (How To Replicate):

  • Click on an Option w/ a Blank Text Box
  • Click Within the Blank Text Box Area w/o Filling in the Entry
  • Attempt to Click on the Next Button (upon hovering it will appear as disabled)
    Kapture 2024-09-07 at 22 16 39
    Kapture 2024-09-07 at 22 19 17

@avenmia
Copy link
Collaborator Author

avenmia commented Sep 14, 2024

@Lawrence-Kwok
For 1. I'm not sure how to clear that styling, let's address this as a separate bug
For 2. I believe that's the expected behavior, if they select an option with a text box they need to enter something in the text box. I feel like the American Indian/Alaska Native should probably not require text, but those were the options I was given so I'm not sure.

Copy link

@Lawrence-Kwok Lawrence-Kwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the issue mentioned earlier (to be handled separately), functionality is as expected with the back and next buttons in regards to returning to the previous question or preventing a user from proceeding with an incomplete entry. LGTM!

@avenmia avenmia merged commit 1a95b73 into main Sep 14, 2024
4 checks passed
@avenmia avenmia deleted the avenmia/FixButtonStyling branch September 14, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants