refactor: Remove unnecessary property and simplify code logic

CodeWithDennis · Mar 16, 2024 · 49acfbb · 49acfbb
1 parent 31e50ff
commit 49acfbb
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/Commands/FilamentResourceTestsCommand.php b/src/Commands/FilamentResourceTestsCommand.php
@@ -20,8 +20,6 @@ class FilamentResourceTestsCommand extends Command
 
     protected Filesystem $files;
 
-    protected string $tests = '';
-
     public function __construct(Filesystem $files)
     {
         parent::__construct();
@@ -42,17 +40,18 @@ protected function convertDoubleQuotedArrayString(string $string): array|string
     protected function getStubVariables(Resource $resource): array
     {
         $model = $resource->getModel();
+        $columns = collect($this->getResourceTable($resource)->getColumns());
 
         return [
             'resource' => str($resource::class)->afterLast('\\'),
             'model' => $model,
             'modelSingularName' => str($model)->afterLast('\\'),
             'modelPluralName' => str($model)->afterLast('\\')->plural(),
-            'resourceTableColumns' => $this->convertDoubleQuotedArrayString(collect($this->getResourceTable($resource)->getColumns())->keys()),
-            'resourceTableColumnsWithoutHidden' => $this->convertDoubleQuotedArrayString(collect($this->getResourceTable($resource)->getColumns())->filter(fn ($column) => ! $column->isToggledHiddenByDefault())->keys()),
-            'resourceTableToggleableColumns' => $this->convertDoubleQuotedArrayString(collect($this->getResourceTable($resource)->getColumns())->filter(fn ($column) => $column->isToggleable())->keys()),
-            'resourceTableSortableColumns' => $this->convertDoubleQuotedArrayString(collect($this->getResourceTable($resource)->getColumns())->filter(fn ($column) => $column->isSortable())->keys()),
-            'resourceTableSearchableColumns' => $this->convertDoubleQuotedArrayString(collect($this->getResourceTable($resource)->getColumns())->filter(fn ($column) => $column->isSearchable())->keys()),
+            'resourceTableColumns' => $this->convertDoubleQuotedArrayString($columns->keys()),
+            'resourceTableColumnsWithoutHidden' => $this->convertDoubleQuotedArrayString($columns->filter(fn ($column) => ! $column->isToggledHiddenByDefault())->keys()),
+            'resourceTableToggleableColumns' => $this->convertDoubleQuotedArrayString($columns->filter(fn ($column) => $column->isToggleable())->keys()),
+            'resourceTableSortableColumns' => $this->convertDoubleQuotedArrayString($columns->filter(fn ($column) => $column->isSortable())->keys()),
+            'resourceTableSearchableColumns' => $this->convertDoubleQuotedArrayString($columns->filter(fn ($column) => $column->isSearchable())->keys()),
         ];
     }