Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where columns that used enums could not be searched #251

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

CodeWithDennis
Copy link
Owner

No description provided.

@CodeWithDennis CodeWithDennis linked an issue Apr 26, 2024 that may be closed by this pull request
@CodeWithDennis
Copy link
Owner Author

In this PR sortable columns are also fixed by using eloquent instead of collection sorting/ordering.

@CodeWithDennis CodeWithDennis merged commit 03421dc into main Apr 26, 2024
1 check passed
@CodeWithDennis CodeWithDennis deleted the 78-bug-columns-with-enums-cant-be-searched branch April 26, 2024 11:33
@dissto
Copy link
Collaborator

dissto commented Apr 28, 2024

@CodeWithDennis does SearchIndividually.php need the same fix?

@CodeWithDennis
Copy link
Owner Author

@CodeWithDennis does SearchIndividually.php need the same fix?

Probably!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Columns with enums can't be searched
2 participants