-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds workflow file to check for labels on PRs #11
Conversation
Fixed typo.
Well, it blocked itself because it didn't have a label. So I guess it works. |
Adding a label doesn't by default trigger the workflow on a PR. I added explicit types for triggering for what I thought were the most likely cases.
After it blocked itself because it had no label, I labeled it and re-ran the check, but it still failed. So I had to close and reopen the PR to get it to pass. According to the GitHub docs on writing workflows, by default a workflow only runs when a PRs activity type is 'opened', 'reopened', or 'synchronize', so I added some activity types to the yml to cover labeling, unlabeling, and editing as well. There are many others I did not add. |
And after I merged Reshama's PR #10 requiring semver labels, it triggered a check automatically on this PR that failed. When I added the semver label, the check triggered again and passed. So I think we did it. Hooray! |
@daslerr It looks like it is working! |
What does this change?
This PR adds a file (check-pr-label.yml) that creates a workflow for checking for release category labels.
Common Theme?
This PR doesn't change Common itself, but it adds a workflow that blocks PRs to common-theme if they do have have one of the release category labels outlined in releases.yml
Issue number: #9
Checklist
Who needs to know about this?
@reshamas @SallyMcGrath @illicitonion