Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/resource page #49

Closed

Conversation

OlhaDanylevska
Copy link

This is a: Bookmark resources implementation

  • [+] ✨ New feature - new behaviour has been implemented
  • 🐛 Bug fix - existing behaviour has been made to behave
  • ♻️ Refactor - the behaviour has not changed, just the implementation
  • Test backfill - tests for existing behaviour were added but the behaviour itself hasn't changed
  • ⚙️ Chore - maintenance task, behaviour and implementation haven't changed

Description

This pull request introduces a new bookmark management system that synchronises bookmarked resources across the Home page and the Bookmarks page, enhancing user experience by ensuring consistency.

  • Purpose -
    This update allows users to efficiently manage their bookmarks, with changes reflected in real-time across different components of the application. Users can now toggle bookmarks on either the Home page or the Bookmarks page, and the changes will immediately be reflected in both locations.

  • How to check

To verify the functionality:

Log in to the application.
Navigate to the Home page and bookmark a resource by toggling the bookmark flag.
Then, go to the Bookmarks page to confirm that the newly bookmarked resource appears there.
Next, remove the bookmark from either page and check that it disappears from both the Home page and the Bookmarks page, confirming the real-time synchronization works as intended.

Links

#36

Author checklist

  • [+] I have written a title that reflects the relevant ticket
  • [+] I have written a description that says what the PR does and how to validate it
  • [+] I have linked to the project board ticket (and any related PRs/issues) in the Links section
  • I have added a link to this PR to the ticket
  • [+] I have made the PR to main from a branch named <category>/<name>, e.g. feature/edit-spaceships or bugfix/restore-oxygen
  • [+] I have manually tested that the app still works correctly
  • [+] I have requested reviewers here and in my team chat channel
  • I have spoken with my PM or TL about any parts of this task that may have become out-of-scope, or any additional improvements that I now realise may benefit my project
  • I have added tests, or new tests were not required
  • I have updated any documentation (e.g. diagrams, schemas), or documentation updates were not required

Screenshots:
Screenshot 2024-10-10 at 13 43 52
Screenshot 2024-10-10 at 13 44 01
Screenshot 2024-10-10 at 13 44 09

textbook and others added 5 commits August 26, 2024 10:08
to add all the bookmarks in one place, created link and route /bookmarks in Header
Added BookmarkFlag icon an functionality
Update bookmarks table for better data integrity.
Add bookmarks linking user_id to resource_id.
Display user-specific bookmarks highlighted in the resource list.
Created a Bookmark Context: To manage shared bookmark state across components.
Wrapped Application: Made the context available throughout the application.
Updated Components: Modified BookmarksPage, HomePage, and ResourceList to utilise the context for managing bookmarks.
Made a Commit: Saved and documented your changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants