Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: react script loop #4022 #4023

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix: react script loop #4022 #4023

merged 1 commit into from
Jul 12, 2023

Conversation

preda-bogdan
Copy link
Contributor

Summary

The useState was creating a render loop since it was dependent on a state that was changed within.

Will affect the visual aspect of the product

NO

Screenshots

Test instructions

  1. On a fresh Neve instance
  2. Enable SCRIPT_DEBUG
  3. Open the browser console
  4. Go to Neve Options > Starter Sites
  5. The error from the issue should not be reported.

Check before Pull Request is ready:

Closes #4022.

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Jun 29, 2023
@pirate-bot
Copy link
Collaborator

Plugin build for 08beeca is ready 🛎️!

@preda-bogdan preda-bogdan added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jun 29, 2023
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Jun 29, 2023
@irinelenache
Copy link
Contributor

@preda-bogdan Tested and the error is gone now, thank you 🚀

@preda-bogdan preda-bogdan merged commit 1eb289f into development Jul 12, 2023
17 of 19 checks passed
@preda-bogdan preda-bogdan deleted the fix/react_loop branch July 12, 2023 15:07
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.6.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants