Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notices from my account page #4064

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

cristian-ungureanu
Copy link
Contributor

@cristian-ungureanu cristian-ungureanu commented Aug 9, 2023

Summary

It seems like the notices under the MyAccount page are not wrapped in the .woocommerce-NoticeGroup class and this class was the one who was responsible for aligning the errors.
I added the .woocommerce-notices-wrapper class right next to the .woocommerce-NoticeGroup so the errors would align well on the account page too

Will affect visual aspect of the product

YES

Screenshots

Checkout-page-check-Check-MyAccount-errors-1-chromium-linux

Test instructions

  • Check that the bug is fixed on the MyAccount page
  • Check that the error on the Checkout page is still looking well ( go to Checkout and try to submit without filling the form )
  • Check the errors on other pages ( eg: https://neve.test/my-account/ when user is logged out and you don't fill the form )

Check before Pull Request is ready:

Closes #4027

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Aug 9, 2023
@pirate-bot
Copy link
Collaborator

pirate-bot commented Aug 9, 2023

Plugin build for 46ba2c7 is ready 🛎️!

@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Aug 9, 2023
@cristian-ungureanu cristian-ungureanu changed the title [WIP] Notices from my account page [#4027] Notices from my account page Aug 9, 2023
@irinelenache
Copy link
Contributor

@cristian-ungureanu Tested and the issue is fixed, didn't find any other problems 🚀

@cristian-ungureanu cristian-ungureanu merged commit 48f6a61 into development Aug 16, 2023
36 of 42 checks passed
@cristian-ungureanu cristian-ungureanu deleted the fix/woo-error-notice branch August 16, 2023 08:55
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.6.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants