Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard permissions #4084

Merged
merged 7 commits into from
Sep 15, 2023
Merged

Conversation

cristian-ungureanu
Copy link
Contributor

@cristian-ungureanu cristian-ungureanu commented Aug 29, 2023

Summary

  • Admin users on multisite are now allowed to access Neve Options.
  • They should be able to:
  • They should not be able to install or click on the install plugins button. They should see a tooltip asking them to ask the admin to install that specific plugin
  • They should be able to create Custom Layouts ( available once you apply the changes from Neve Pro )
  • They should NOT be able to edit a custom layout in PHP mode ( available once you apply the changes from Neve Pro )

Will affect the visual aspect of the product

NO

Test instructions

  • Please test the features described in the Summary section.
  • Please check other potential places that I might have missed. Look for buttons that install or activate plugins. For example, they can appear in notices like this one:
    Screenshot 2023-08-29 at 13 19 21
  • Check the tab when TPC is not installed, there is a button there too.
  • For the last two points from summary, check https://github.com/Codeinwp/neve-pro-addon/pull/2620

NOTE: Everything else related to TPC will be treated in a separate issue.

Check before Pull Request is ready:

Closes #4036

@cristian-ungureanu cristian-ungureanu added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 29, 2023
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 29, 2023
@pirate-bot
Copy link
Collaborator

pirate-bot commented Aug 29, 2023

Plugin build for 1c1d7e0 is ready 🛎️!

@cristian-ungureanu cristian-ungureanu merged commit 96827ec into development Sep 15, 2023
15 checks passed
@cristian-ungureanu cristian-ungureanu deleted the fix/dashboard-permissions branch September 15, 2023 15:51
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neve Options page can not be accessed by non super admin users on multisite network
3 participants