Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hero btn onboarding on large text #4254

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jun 21, 2024

Summary

  • Changed the primary hero button to be more flexible and not break the layout when it contains a large text (generated by the translations).
  • Also balanced the design. (centered text and lower line-height, thanks to @mghenciu )

Will affect visual aspect of the product

NO

Screenshots

image

image

image

Test instructions

  • In fresh instances with the Romanian Language, install Neve. (Alternatively you can edit the HTML directly in the page to add some extra text )
  • Check the onboarding notice.

Note

When testing with TasteWP, make sure do not have Neve installed already when you try to put the new build. TasteWP might server some cached file!

Check before Pull Request is ready:

Closes #4240

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jun 21, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Jun 21, 2024 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jun 21, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review June 21, 2024 11:26
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jun 21, 2024

Plugin build for 899aa75 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jun 21, 2024
@rodica-andronache
Copy link
Contributor

@Soare-Robert-Daniel I've tried on instawp and on local and this is how it looks for me https://vertis.d.pr/v/r6dPgc
The correct layout is visible just for seconds, when I clear the cache. Is there something I'm missing?

@Soare-Robert-Daniel
Copy link
Contributor Author

The unexpected behavior was caused by a React component that replaced the PHP-generated content. This component used a button element instead of the original a tag, which our selector overlooked. I've updated the selector to account for both cases,

@rodica-andronache
Copy link
Contributor

@Soare-Robert-Daniel it's working well now 👍

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit da3a223 into development Jul 2, 2024
15 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/hero-btn-large-text branch July 2, 2024 10:12
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this pull request Jul 2, 2024
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text overlapping in Onboarding notice in other languages
4 participants