Fixed duplicate id issue with secondary nav menu

[girishpanchal30]

Summary

When the page load, I count the number of secondary menus and add it to the nav menu wrap ID.
e.g: secondary-menu_2
ref: https://github.com/Codeinwp/neve/blob/master/.storybook/dummy-data.js#L514

Test instructions

1. Create Wordpress site with Neve.
2. Add a header element to both desktop and mobile view (for example a secondary menu)
3. Save
4. The HTML source will contain duplicate id values (e.g. secondary-menu)

Check before Pull Request is ready:

• I have run all tests and they pass
• The code passes when running the PHP CodeSniffer
• Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
• Security and Sanitization requirements have been followed
• I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes #4256

[pirate-bot]

Plugin build for 5e821df is ready 🛎️!

• Download build

[preda-bogdan]

I think the solution is not complete, there are other components that might have the same problem and we should see if we can just switch to relying on classes and have an unique id for each instance (desktop/mobile) based on. the parent.

[girishpanchal30]

@preda-bogdan As per your comment I've created unique ID based components, please review my latest commit and let me know if need any changes.

[preda-bogdan]

I will approve this change, it would help to have a test for this specific case.
My original comment still stands, I think this will solve this issue but there might still be other components that will behave the same.
Also, it is not required to remove checklist items from PR, you can add the pr-checklist-skip tag if you intend to not add any tests.

[rodica-andronache]

@girishpanchal30 it's not working for me, let me know if I'm missing something.

This is how I added the secondary menu on desktop https://vertis.d.pr/i/xPdUSS , on mobile https://vertis.d.pr/i/tAcdor and the ID is duplicated https://vertis.d.pr/i/etW95L

[girishpanchal30]

@rodica-andronache It seems we need to add the device name in the ID to create a unique ID based on components and devices.
Please check with the latest build zip.

[rodica-andronache]

@girishpanchal30 thank you! It works well now 👍

[pirate-bot]

🎉 This PR is included in version 3.8.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀