This repository has been archived by the owner on Mar 14, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
disable check to see if form has been updated #332
Open
contactashish13
wants to merge
188
commits into
Codeinwp:gt-integration
Choose a base branch
from
contactashish13:issue-226
base: gt-integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
disable check to see if form has been updated #332
contactashish13
wants to merge
188
commits into
Codeinwp:gt-integration
from
contactashish13:issue-226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recaptch js loaded all over frontend #221
toggle password field
remove hide/show of recaptcha and make custom spam trap default
change error messages so that the type of error is obvious
Improved assets loading, loading them only they are necessary. Remove hide/show effect for reCaptcha. Add toggle for password field. Add new docs, keeping them in sync with HelpScout . Adds more integration with the pro version.
…oggle add password toggle to smtp password field
Adds compatibility with WordPress 4.9 Minor improvement for toggle the password in the admin form fields.
GDPR compliance
Conflict with wpdatatables plugin
add ajax support #305
HardeepAsrani
approved these changes
Jul 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine for me now. Just make sure that you remove the console.log comments. :)
Also, can you filter the rendered HTML to make all the elements disabled so people can't use them?
@HardeepAsrani it works fine because the loading of potentially-changed forms is disabled now :) Can you please enable that check and see what could be the problem? I have highlighted with comments where the problem stems from. |
@contactashish13 I've no idea it's too confusing as I don't understand the logic of things going on. It's too confusing here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#226
Can you review this? I have disabled the code that checks if the form has been reloaded. It can be reactivated by returning true in
checkIfSavedFormHasChanged
.