Skip to content
This repository has been archived by the owner on Mar 14, 2021. It is now read-only.

disable check to see if form has been updated #332

Open
wants to merge 188 commits into
base: gt-integration
Choose a base branch
from

Conversation

contactashish13
Copy link
Contributor

#226

Can you review this? I have disabled the code that checks if the form has been reloaded. It can be reactivated by returning true in checkIfSavedFormHasChanged.

contactashish13 and others added 30 commits November 7, 2017 23:01
recaptch js loaded all over frontend #221
remove hide/show of recaptcha and make custom spam trap default
change error messages so that the type of error is obvious
Improved assets loading, loading them only they are necessary. 
Remove hide/show effect for reCaptcha.
Add toggle for password field.
Add new docs, keeping them in sync with HelpScout . 
Adds more integration with the pro version.
…oggle

add password toggle to smtp password field
Adds compatibility with WordPress 4.9
Minor improvement for toggle the password in the admin form fields.
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine for me now. Just make sure that you remove the console.log comments. :)

Also, can you filter the rendered HTML to make all the elements disabled so people can't use them?

@contactashish13
Copy link
Contributor Author

@HardeepAsrani it works fine because the loading of potentially-changed forms is disabled now :) Can you please enable that check and see what could be the problem? I have highlighted with comments where the problem stems from.

@HardeepAsrani
Copy link
Member

@contactashish13 I've no idea it's too confusing as I don't understand the logic of things going on. It's too confusing here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants