Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: featured available on in some free plugins #237

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

preda-bogdan
Copy link
Contributor

Summary

The featured module was being loaded for slugs that contained pro as part of another word eg. product.
I changed the check to account for that and introduced a test for this case.

How to test

  1. Using WooCommerce Product Addon and this build of the SDK
  2. Check that the Featured products are not visible inside the Featured Plugins page.
  3. All tests should pass.

Closes: Codeinwp/themeisle#1652

References: Codeinwp/themeisle#1652
Copy link

github-actions bot commented Jun 5, 2024

Plugin build for 9bc0688 is ready 🛎️!

src/Modules/Featured_plugins.php Outdated Show resolved Hide resolved
@preda-bogdan preda-bogdan merged commit 061916f into development Jun 25, 2024
4 checks passed
@preda-bogdan preda-bogdan deleted the fix/featured_plugins branch June 25, 2024 09:23
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.3.24 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants