Add E2E support #240
Add E2E support #240
Conversation
Soare-Robert-Daniel
force-pushed
the
chore/e2e
branch
6 times, most recently
from
a1e07fd
to
ea743c0
Compare
Soare-Robert-Daniel
force-pushed
the
chore/e2e
branch
2 times, most recently
from
3b74d68
to
abcff12
Compare
Soare-Robert-Daniel
requested review from
abaicus,
carlalexander and
HardeepAsrani
There was a problem hiding this comment.
I've left a lot of notes. I think we should use this opportunity to shore up a few things related to testing. I've mentioned @selul a few times to see what he thinks.
Thank you for all your work! 🥳
| key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-composer- | ||
| - name: Install composer deps |
There was a problem hiding this comment.
I think we should still use setup-php here to make sure we can control the PHP version. We don't know how GHA will update it.
What does it run it against right now?
.github/workflows/e2e.yml
Outdated
| - name: Get Composer Cache Directory | ||
| id: composer-cache | ||
| run: | | ||
| echo "::set-output name=dir::$(composer config cache-files-dir)" | ||
| - name: Configure Composer cache | ||
| uses: actions/cache@v1 | ||
| with: | ||
| path: ${{ steps.composer-cache.outputs.dir }} | ||
| key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-composer- |
There was a problem hiding this comment.
Maybe @selul can chime in as well, but I don't know if doing this is necessary anymore. I used to do that a long time ago especially with Composer v1 which was slower. I don't do that anymore.
I see this is in test-php as well. Maybe we could remove it there as well and make this a larger testing improvement pass.
There was a problem hiding this comment.
It makes sense, I think this is from a few years back.
.github/workflows/test-php.yml
Outdated
| @@ -47,7 +47,7 @@ jobs: | |||
| - name: Setup PHP version | |||
| uses: shivammathur/setup-php@v2 | |||
| with: | |||
| php-version: '7.2' | |||
| php-version: "7.4" | |||
There was a problem hiding this comment.
@selul how would you feel about using this opportunity to switch this to a test matrix. We should run PHP tests against PHP 7.4, 8.0, 8.1, 8.2. and 8.3.
| .DS_Store | ||
| .idea | ||
| node_modules | ||
| .vscode |
There was a problem hiding this comment.
We shouldn't add things related to the operating system or the IDE to .gitignore. Every developer should have a global .gitignore to take of that. I'll make a note in Slack 😃
Soare-Robert-Daniel
force-pushed
the
chore/e2e
branch
2 times, most recently
from
4dc00c3
to
50ed5eb
Compare
Soare-Robert-Daniel
force-pushed
the
chore/e2e
branch
from
50ed5eb
to
4d9d200
Compare
Add E2E test support via Playwright and Gutenberg utils packages.
Implemented test:
Others
wp-envtracking.js