Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new signing options by default for twitter #901

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

preda-bogdan
Copy link
Contributor

Summary

Changed the sign-in workflow for Twitter to prioritise user key login first.
Added notice about Twitter default app limitations.
Changed branding for Twitter sign in.

Screenshots

New X flow

image
image
image
image

Testing Instructions

  1. On an instance that is publicly accesible
  2. Install the ROP plugin
  3. Create a Twitter application following the steps from here: https://docs.revive.social/article/1908-how-to-solve-453-twitter-error-in-rop
  4. Use the Twitter application keys to login via twitter

References: Codeinwp/tweet-old-post-pro#476

Copy link

github-actions bot commented Dec 21, 2023

Plugin build for fe06f63 is ready 🛎️!

@preda-bogdan preda-bogdan force-pushed the feat/twitter_api_defaults branch from 4d212e6 to fe06f63 Compare December 21, 2023 14:57
@vytisbulkevicius vytisbulkevicius merged commit c5e36da into development Dec 22, 2023
6 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 9.0.22 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants