Merge pull request #383 from Codeminer42/fix/projects-load-time

Fix the load speed of projects after choosing a team

CHANGELOG.md

@@ -1,6 +1,8 @@
 # Changelog
 
 ## [Unreleased]
+### Removed
+- Remove Velocity / Volatility from ProjectCard to optimize performance
 
 ## [1.20.0] 2018-09-14
 ### Added

app/assets/javascripts/components/projects/ProjectCard.js

@@ -97,16 +97,6 @@ export default class ProjectCard extends React.Component {
     if (joined) {
       return(
         <div className="panel-body">
-          <div className="col-md-6 col-xs-6 counter">
-            <span className="counter-description">{ I18n.t('velocity') }</span>
-            <span className="counter-value">{ project.get('velocity') }</span>
-          </div>
-
-          <div className="col-md-6 col-xs-6 counter">
-            <span className="counter-description">{ I18n.t('volatility') }</span>
-            <span className="counter-value">{ project.get('volatility') }</span>
-          </div>
-
           <div className="col-md-12 members">
             <ul className="member-list">
               { this.renderUsersAvatar() }

app/assets/stylesheets/_members.scss

@@ -1,7 +1,6 @@
 .members {
   display: table;
   margin: 0 auto;
-  margin-top: 15px;
   text-align: center;
 
   .member-list {

app/serializers/project_serializer.rb

@@ -13,8 +13,6 @@ class ProjectSerializer
 
   def initialize(attrs = {})
     self.name = attrs.truncate_name
-    self.velocity = attrs.velocity
-    self.volatility = attrs.volatility
     self.slug = attrs.slug
     self.path_to = attrs.path_to
     self.archived_at = attrs.archived_date

spec/javascripts/components/projects/project_card_spec.js

@@ -147,26 +147,6 @@ describe('<ProjectCard />', () => {
 
     describe('#panelBody', () => {
       describe('not archived', () => {
-        it('should contain velocity information', () => {
-          const wrapper = shallow(<ProjectCard {...defaultProps} />);
-          expect(wrapper.contains(
-            <div className="col-md-6 col-xs-6 counter">
-              <span className="counter-description">{ I18n.t('velocity') }</span>
-              <span className="counter-value">10</span>
-            </div>
-          )).toBe(true);
-        });
-
-        it('should contain volatility information', () => {
-          const wrapper = shallow(<ProjectCard {...defaultProps} />);
-          expect(wrapper.contains(
-            <div className="col-md-6 col-xs-6 counter">
-              <span className="counter-description">{ I18n.t('volatility') }</span>
-              <span className="counter-value">0%</span>
-            </div>
-          )).toBe(true);
-        });
-
         it('should contain users avatar', () => {
           const wrapper = shallow(<ProjectCard {...defaultProps} />);
           expect(wrapper.contains(

spec/serializers/project_serializer_spec.rb

@@ -12,14 +12,6 @@
     expect(project.truncate_name).to eq(serialized_project.name)
   end
 
-  it 'should have a velocity that matches' do
-    expect(project.velocity).to eq(serialized_project.velocity)
-  end
-
-  it 'should have a volatility that matches' do
-    expect(project.volatility).to eq(serialized_project.volatility)
-  end
-
   it 'should have a slug that matches' do
     expect(project.slug).to eq(serialized_project.slug)
   end