Enable RedundantReturn rucobop style

.rubocop.yml

@@ -27,9 +27,6 @@ Documentation:
 Style/Semicolon:
   AllowAsExpressionSeparator: true
 
-Style/RedundantReturn:
-  Enabled: false
-
 Style/ClassAndModuleChildren:
   Enabled: false
 

CHANGELOG.md

@@ -8,6 +8,7 @@
 - Added flag to mail reports
 - Enabled AndOr rubocop style
 - Enabled BlockNesting rubocop metric
+- Enabled RedundantReturn rubocop style
 
 ### Changed
 - Move users/form from projects to teams

app/controllers/concerns/sidebar_controller.rb

@@ -7,7 +7,7 @@ def define_sidebar(sidebar)
     end
 
     def sidebar
-      return @sidebar
+      @sidebar
     end
   end
 end

lib/tasks/i18n_missing_keys.rake

@@ -43,7 +43,7 @@ class MissingKeysFinder
     end
 
     output_missing_keys(missing_keys)
-    return missing_keys
+    missing_keys
   end
 
   def add_missing_key(missing_keys, key, locale, skip)
@@ -75,18 +75,18 @@ class MissingKeysFinder
   end
 
   def collect_keys(scope, translations)
-    full_keys = []
-    translations.to_a.each do |key, translation|
-      next if translation.nil?
-
-      new_scope = scope.dup << key
-      if translation.is_a?(Hash)
-        full_keys += collect_keys(new_scope, translation)
-      else
-        full_keys << new_scope.join('.')
+    [].tap do |full_keys|
+      translations.to_a.each do |key, translation|
+        next if translation.nil?
+
+        new_scope = scope.dup << key
+        if translation.is_a?(Hash)
+          full_keys += collect_keys(new_scope, translation)
+        else
+          full_keys << new_scope.join('.')
+        end
       end
     end
-    return full_keys
   end
 
   # Returns true if key exists in the given locale