Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config with inherited property bug #789

Merged
merged 2 commits into from
Oct 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions MJExtension/NSObject+MJClass.m
Original file line number Diff line number Diff line change
Expand Up @@ -145,31 +145,33 @@ + (void)mj_setupBlockReturnValue:(id (^)(void))block key:(const char *)key
MJExtensionSemaphoreSignal
}

+ (NSMutableArray *)mj_totalObjectsWithSelector:(SEL)selector key:(const char *)key
{
+ (NSMutableArray *)mj_totalObjectsWithSelector:(SEL)selector key:(const char *)key {
MJExtensionSemaphoreCreate
MJExtensionSemaphoreWait
NSMutableArray *array = [self mj_classDictForKey:key][NSStringFromClass(self)];
if (array == nil) {
// 创建、存储
[self mj_classDictForKey:key][NSStringFromClass(self)] = array = [NSMutableArray array];

if ([self respondsToSelector:selector]) {
NSMutableSet *classMethodSets = NSMutableSet.set;
[self mj_enumerateAllClasses:^(__unsafe_unretained Class c, BOOL *stop) {
Method method = class_getClassMethod(c, selector);
NSNumber *methodAddress = @((int64_t)(void *)method);
if (method && ![classMethodSets containsObject:methodAddress]) {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Warc-performSelector-leaks"
NSArray *subArray = [self performSelector:selector];
NSArray *subArray = [c performSelector:selector];
#pragma clang diagnostic pop
if (subArray) {
[array addObjectsFromArray:subArray];
if (subArray) {
[array addObjectsFromArray:subArray];
}
[classMethodSets addObject:methodAddress];
}
}

[self mj_enumerateAllClasses:^(__unsafe_unretained Class c, BOOL *stop) {
NSArray *subArray = objc_getAssociatedObject(c, key);
[array addObjectsFromArray:subArray];
}];
}
MJExtensionSemaphoreSignal
return array;
}

@end
12 changes: 9 additions & 3 deletions MJExtensionDemo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
2D2DBA832317DBE0005A689E /* MJAd.m in Sources */ = {isa = PBXBuildFile; fileRef = 2D2DBA732317DBDF005A689E /* MJAd.m */; };
2D2DBA842317DBE0005A689E /* MJExtensionConfig.m in Sources */ = {isa = PBXBuildFile; fileRef = 2D2DBA752317DBDF005A689E /* MJExtensionConfig.m */; };
2D2DBA852317DBE0005A689E /* MJPerson.m in Sources */ = {isa = PBXBuildFile; fileRef = 2D2DBA772317DBDF005A689E /* MJPerson.m */; };
6B431A1D253F2EA900F08763 /* MJElement.m in Sources */ = {isa = PBXBuildFile; fileRef = 6B431A1C253F2EA900F08763 /* MJElement.m */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
Expand Down Expand Up @@ -155,6 +156,8 @@
2D2DBA762317DBDF005A689E /* MJBook.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MJBook.h; sourceTree = "<group>"; };
2D2DBA772317DBDF005A689E /* MJPerson.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = MJPerson.m; sourceTree = "<group>"; };
2D2DBA872317DCCF005A689E /* PrefixHeader.pch */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = PrefixHeader.pch; sourceTree = "<group>"; };
6B431A1B253F2EA900F08763 /* MJElement.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MJElement.h; sourceTree = "<group>"; };
6B431A1C253F2EA900F08763 /* MJElement.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = MJElement.m; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
Expand Down Expand Up @@ -289,18 +292,20 @@
2D2DBA602317DBDF005A689E /* MJDog.m */,
2D2DBA6B2317DBDF005A689E /* MJExtensionConfig.h */,
2D2DBA752317DBDF005A689E /* MJExtensionConfig.m */,
0130EE7E233C56D8008D2386 /* MJFrenchUser.h */,
0130EE7F233C56D8008D2386 /* MJFrenchUser.m */,
2D2DBA682317DBDF005A689E /* MJPerson.h */,
2D2DBA772317DBDF005A689E /* MJPerson.m */,
2D2DBA622317DBDF005A689E /* MJStatus.h */,
2D2DBA722317DBDF005A689E /* MJStatus.m */,
2D2DBA642317DBDF005A689E /* MJStatusResult.h */,
2D2DBA712317DBDF005A689E /* MJStatusResult.m */,
2D2DBA662317DBDF005A689E /* MJStudent.m */,
2D2DBA6F2317DBDF005A689E /* MJStudent.h */,
2D2DBA662317DBDF005A689E /* MJStudent.m */,
2D2DBA672317DBDF005A689E /* MJUser.h */,
2D2DBA6E2317DBDF005A689E /* MJUser.m */,
0130EE7E233C56D8008D2386 /* MJFrenchUser.h */,
0130EE7F233C56D8008D2386 /* MJFrenchUser.m */,
6B431A1B253F2EA900F08763 /* MJElement.h */,
6B431A1C253F2EA900F08763 /* MJElement.m */,
);
path = Model;
sourceTree = "<group>";
Expand Down Expand Up @@ -501,6 +506,7 @@
2D2DBA842317DBE0005A689E /* MJExtensionConfig.m in Sources */,
2D2DBA7F2317DBE0005A689E /* MJBaseObject.m in Sources */,
2D2DBA7D2317DBE0005A689E /* MJBook.m in Sources */,
6B431A1D253F2EA900F08763 /* MJElement.m in Sources */,
2D2DBA7A2317DBE0005A689E /* MJDog.m in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down
13 changes: 13 additions & 0 deletions MJExtensionTests/MJExtensionTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#import <CoreData/CoreData.h>
#import "MJFrenchUser.h"
#import "MJCat.h"
#import "MJElement.h"

@interface MJExtensionTests : XCTestCase

Expand Down Expand Up @@ -525,4 +526,16 @@ - (void)testLogAllProperties {

MJExtensionLog(@"%@", user);
}

#pragma mark 使用 mj_ignoredPropertyNames/mj_allowedPropertyNames 存在继承
- (void)testIgnoredInheritedProperties {
NSDictionary *dict = @{
@"count" : @"100",
@"renderName" : @"MJRenderElementName"
};
MJRenderElement *renderElement = [MJRenderElement mj_objectWithKeyValues:dict];
XCTAssert(renderElement.count == 0);
XCTAssertFalse(renderElement.renderName);
}

@end
26 changes: 26 additions & 0 deletions MJExtensionTests/Model/MJElement.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
//
// MJElement.h
// MJExtensionTests
//
// Created by libin14 on 2020/10/20.
// Copyright © 2020 MJ Lee. All rights reserved.
//

#import <Foundation/Foundation.h>

NS_ASSUME_NONNULL_BEGIN

@interface MJElement : NSObject

@property (assign, nonatomic) NSInteger count;

@end


@interface MJRenderElement : MJElement

@property (copy, nonatomic) NSString *renderName;

@end

NS_ASSUME_NONNULL_END
26 changes: 26 additions & 0 deletions MJExtensionTests/Model/MJElement.m
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
//
// MJElement.m
// MJExtensionTests
//
// Created by libin14 on 2020/10/20.
// Copyright © 2020 MJ Lee. All rights reserved.
//

#import "MJElement.h"

@implementation MJElement

+ (NSArray *)mj_ignoredPropertyNames {
return @[@"count"];
}

@end

@implementation MJRenderElement

+ (NSArray *)mj_ignoredPropertyNames {
return @[@"renderName"];
}

@end