Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper transition with objects for avatars #157

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

paoloricciuti
Copy link
Contributor

What type of Pull Request is this?

Delete all options except for the one that applies

  • Bug fix

What is the current behavior?

The view transition currently doesn't work if you have multiple avatar of the same channel on the same page

Issue Number: N/A

What is the new behavior?

  • by using the proper object syntax the transition is much more snappier and it works even if other lists have the same channel avatar

Other information

Copy link
Member

@w3cj w3cj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@w3cj w3cj merged commit 495b825 into CodingGarden:main Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants