Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Docker setup 🐳 #84

Closed
wants to merge 6 commits into from
Closed

Docker setup 🐳 #84

wants to merge 6 commits into from

Conversation

tejas-hosamani
Copy link
Contributor

No description provided.

@snordmann
Copy link
Member

Shouldn't the env for the containers be set in the docker-compose file?

@tejas-hosamani
Copy link
Contributor Author

tejas-hosamani commented Sep 11, 2019

Yes, you are absolutely right. I 'll update it first thing in the morning!

@snordmann
Copy link
Member

Could you please also add a documentation on how to run the development environment in the README.md? Otherwise I don't see any problem to merge this. Good work 👍

@tejas-hosamani
Copy link
Contributor Author

tejas-hosamani commented Sep 13, 2019

Yes, I ll. I had planned to do so after having proper Docker setup. I have another minor update to make and then I'll have the README.md file updated.

And thank you for your kind encouragement. 🙂

@tejas-hosamani
Copy link
Contributor Author

tejas-hosamani commented Oct 4, 2019

I might have to set up this whole thing again and submit new PR. I don't even remember what I did so far. I 'll just leave this PR for ref for now.

@spiray
Copy link
Contributor

spiray commented Oct 7, 2019

@CodingCreate101 Should this be closed? Or do you want to wait until #87 is merged?

@tejas-hosamani
Copy link
Contributor Author

I'd like to wait until the other one is merged if that's okay. I'd like to have this a reference, yet.

@tejas-hosamani
Copy link
Contributor Author

Closing the PR. Please keep the branch, though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants