Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

[CA-117] Added Vuex. Also integrated it with FAQs. #19

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[CA-117] Added Vuex. Also integrated it with FAQs. #19

wants to merge 1 commit into from

Conversation

tejas-hosamani
Copy link
Contributor

No description provided.

rabbitwerks
rabbitwerks suggested changes Oct 15, 2019
View reviewed changes
Copy link
Member

@rabbitwerks rabbitwerks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I would clean up the function names to keep consistency, versus snake case to camelCase

Also we should have better prop checking, type and required attribute so if props dont get passed in and checked they will error.

@tejas-hosamani
Copy link
Contributor Author

As a Developer, I want to have State located in a centralized Store

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rabbitwerks rabbitwerks rabbitwerks requested changes

@AndCotOli AndCotOli Awaiting requested review from AndCotOli

@joshuaferr1s joshuaferr1s Awaiting requested review from joshuaferr1s

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tejas-hosamani @rabbitwerks