Make DBus calls in async operations async #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app_dl is a leftover from a previous cleanup Fixes 7b2fb1e
This avoids synchronously blocking the main thread on an operation that can be slow and has the potential to freeze the UI. Relates #44
This avoids blocking on refines, which run very often and can spontaneously and shortly block the UI. Relates #44
|
Tested in https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/40531 works well. Opened #60 to track better error handling on upgrades. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async operations run in the main context. Therefore, long blocks in DBus calls can (and do) easily freeze the UI. Fix this by using async DBus calls.
Fixes #44
Add a commit that also fixes #57