Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS 43 #61

Merged
merged 9 commits into from
Jan 3, 2023
Merged

GS 43 #61

merged 9 commits into from
Jan 3, 2023

Conversation

pabloyoyoista
Copy link
Collaborator

Closes #58

@pabloyoyoista pabloyoyoista marked this pull request as ready for review November 11, 2022 13:36
@pabloyoyoista pabloyoyoista changed the title WIP: GS 43 GS 43 Nov 11, 2022
@pabloyoyoista
Copy link
Collaborator Author

This is now ready! The "Run tests" is failing, but I have not managed to avoid it from running. The fact that the container task works means that this is functional. Also tested locally.

@pabloyoyoista
Copy link
Collaborator Author

Added commit to sync launch app function with upstream.

@Cogitri Cogitri merged commit 9beae29 into Cogitri:master Jan 3, 2023
@pabloyoyoista pabloyoyoista deleted the gs-43 branch January 5, 2023 08:46
@pabloyoyoista
Copy link
Collaborator Author

Thanks! Did you test this any further? I'd like #63 and #65 to be fixed before doing a new release, since they'd help a lot with performance and polish :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in 43
2 participants