Upgrade to GNOME 44+ compatibility #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate" This is to simplify the future change to the async API. Only having to take care of one list simplifies the work there. It should have no behavior change in the current code, apart from moving complexity from the after-math logic to the preparation one
…_process We don't really want to test the GS library API. What we want is to make sure that the apps we wanted updated are updated, and the ones that we didn't want updated stay as they were. Since we have the apps in the context, use them!
This was quite trivial, and the only change in cycles 44 and 45, so a great success overall
Which is basically current main, with https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/1798 applied.
pabloyoyoista
force-pushed
the
gs-45
branch
from
042709f
to
b00c274
Compare
|
@Cogitri any idea on how to fix the pipeline issue? dbus-daemon[99]: Failed to start message bus: Failed to bind socket "/var/run/dbus/system_bus_socket": No such file or directory This is successfully running locally though :D |
|
Huh, maybe that's GH actions doing some security magic? |
|
I guess we could disable tests in the image build for now since we run them in a separate CI job as well |
|
Well, it's done like this, because the regular test job will fail until the new image uploads. And I'd bet they have the same issue. Dang :( |
|
Would you be open to merging in this state? Locally the tests are passing at least... |
Avoid the system bus, since otherwise needs roots permissions, and is more cumbersome to setup
|
Fix the tests! The run tests is failing due to the image not being available, but the rest is fixed! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69