Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate messgaes in history after re-connecting (v2) #412

Merged

Conversation

sushmi21
Copy link
Collaborator

@sushmi21 sushmi21 commented May 2, 2024

This PR prevents duplicate messages in chat history by not prepending messages to the message history on re-connect.

Success Criteria:

  • Reconnecting behaviour should remain unaffected. Reconnect screen should appear, chat history should not disappear
  • In chat history, redunant messages should not appear on re-connecting
  • please do a thorough testing to avoid regression

How to test:

  • Send a message to the bot and wait for a response.
  • Now, in browser console, select network to 'Offline' or simply disconnect your PC's wifi
  • After few minutes, put your network to 'No throttling' or connect the wifi back.
  • Check SC

@sushmi21
Copy link
Collaborator Author

sushmi21 commented May 2, 2024

I have added a comment and just commented the line of code instead of removing it, for future reference.

@sushmi21 sushmi21 requested a review from kwinto May 2, 2024 11:04
@sushmi21 sushmi21 merged commit cfd69d4 into master May 7, 2024
3 checks passed
@sushmi21 sushmi21 changed the title Fix dplicate messgaes in history after re-connecting Fix duplicate messgaes in history after re-connecting (v2) May 7, 2024
@sushmi21 sushmi21 mentioned this pull request May 8, 2024
@Dujma
Copy link

Dujma commented May 13, 2024

This also fixes this ticket? #335

So I can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants