Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate message in history on re-connect in (v3) #415

Merged

Conversation

sushmi21
Copy link
Collaborator

@sushmi21 sushmi21 commented May 7, 2024

This PR prevents duplicate messages in chat history by not prepending messages to the message history on re-connect.

Success Criteria:

  • Reconnecting behaviour should remain unaffected. Reconnect screen should appear, chat history should not disappear
  • In chat history, redunant messages should not appear on re-connecting
  • please do a thorough testing to avoid regression
  • When a session id is defined in index.html, then the chat history should be restored even after page reload
  • When session id is not defined in index.htm, then reloding the page should clear the chat history

How to test:

  • Send a message to the bot and wait for a response.
  • Now, in browser console, select network to 'Offline' or simply disconnect your PC's wifi
  • After few minutes, put your network to 'No throttling' or connect the wifi back.
  • Check SC

@sushmi21 sushmi21 requested a review from kwinto May 7, 2024 09:49
@sushmi21 sushmi21 changed the title Avoid duplicate message in history on re-connect in v3 Avoid duplicate message in history on re-connect in (v3) May 7, 2024
@kwinto kwinto merged commit 1bc63ea into v3 May 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants