Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL direction fixes #446

Merged
merged 9 commits into from
Jul 22, 2024
Merged

RTL direction fixes #446

merged 9 commits into from
Jul 22, 2024

Conversation

kwinto
Copy link
Contributor

@kwinto kwinto commented Jul 12, 2024

This PR fixes some issues for the RTL locales.

How to test

@kwinto kwinto requested a review from sushmi21 July 12, 2024 12:32
@sushmi21
Copy link
Collaborator

The chat toggle button itself appears in the left corner. I think this should not be affected.

Screenshot from 2024-07-18 16-29-27

@sushmi21
Copy link
Collaborator

sushmi21 commented Jul 18, 2024

I remember we talked about switching the position of the icons. The icons are not still not switched. For example, the back button is to the right instead of left. This applies to send button, close button etc.
Screenshot from 2024-07-18 17-17-07

@kwinto
Copy link
Contributor Author

kwinto commented Jul 18, 2024

I remember we talked about switching the position of the icons. The icons are not still not switched. For example, the back button is to the right instead of left. This applies to send button, close button etc. Screenshot from 2024-07-18 17-17-07

It is actually flipped. It is showing now to the "back direction" in RTL :-)

@kwinto
Copy link
Contributor Author

kwinto commented Jul 18, 2024

The chat toggle button itself appears in the left corner. I think this should not be affected.

Screenshot from 2024-07-18 16-29-27

It should definitely appear on the left.

In RTL localized websites, everything becomes “flipped” to usual for us direction, even the logotypes and such.

@sushmi21
Copy link
Collaborator

I remember we talked about switching the position of the icons. The icons are not still not switched. For example, the back button is to the right instead of left. This applies to send button, close button etc. Screenshot from 2024-07-18 17-17-07

It is actually flipped. It is showing now to the "back direction" in RTL :-)

What I meant is the position of the buttons. The group of buttons like (minimize, close and chat options should be on the right) and the back button should be on the left, don't you think?

@kwinto
Copy link
Contributor Author

kwinto commented Jul 19, 2024

I remember we talked about switching the position of the icons. The icons are not still not switched. For example, the back button is to the right instead of left. This applies to send button, close button etc. Screenshot from 2024-07-18 17-17-07

It is actually flipped. It is showing now to the "back direction" in RTL :-)

What I meant is the position of the buttons. The group of buttons like (minimize, close and chat options should be on the right) and the back button should be on the left, don't you think?

I think you got confused here. Originally, the close button is on the right. Now, in RTL, it is on the left. So we actually have flipped the position.

@sushmi21
Copy link
Collaborator

I remember we talked about switching the position of the icons. The icons are not still not switched. For example, the back button is to the right instead of left. This applies to send button, close button etc. Screenshot from 2024-07-18 17-17-07

It is actually flipped. It is showing now to the "back direction" in RTL :-)

What I meant is the position of the buttons. The group of buttons like (minimize, close and chat options should be on the right) and the back button should be on the left, don't you think?

I think you got confused here. Originally, the close button is on the right. Now, in RTL, it is on the left. So we actually have flipped the position.

No, I am not confused. I am saying that we should only flip the chat bubbles but not the icon positions. All icons should stay in their original position, don't you think?

@kwinto kwinto merged commit 85f08ff into v3 Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants