Fix/dexalot lost orders fix #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # hummingbot/connector/derivative/kucoin_perpetual/kucoin_perpetual_derivative.py
# Conflicts: # test/hummingbot/connector/derivative/binance_perpetual/test_binance_perpetual_derivative.py
If the transaction was recently submitted, an order status request could fail to find the transaction data. This was considered as order failure up until now, but it should be considered as "order not found".
|
This pull request has been linked to Shortcut Story #45141: Dexalot - Stuck on cancelling order. |
rxlxrxsx
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Tested and confirmed working by QA.
- Successfully cloned and installed the branch
- Successfully setup gateway both on source and docker
- Connected API keys (valid and invalid key) and confirmed working as expected
- Confirmed wallet and exchange balances are reflecting correct
- Created a pure_mm strategy and went through initial prompts successfully
- Started the strategy without issues, confirmed orders are created and cancelled based on config
- Confirmed order book prices is in sync with the exchange
- Trade information are correct based on history command output
- Compared trades in client and exchange, no discrepancies found
- Confirmed hanging order/cancellation and multiple order levels works as expected
|
Closing to re-open towards foundation: hummingbot#6611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR addresses the issue where Dexalot orders remain stuck (orphaned) on the exchange.
[ch-45141]
Tests performed by the developer:
Unit tests.
Tips for QA testing:
Please ensure the behaviour is no longer reproducible.