Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adjust z-index of Scroll section. #10783

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

gokaysatir
Copy link
Contributor

@gokaysatir gokaysatir commented Dec 20, 2024

Because other sections need to read the up-to-date data that is updated by scroll section, we need to set its z-index to a higher value.

Issue: AutoFill marker section drawing lags behind while scrolling.

Also refactored some of the things in the file, without changing the logic.

Change-Id: Ia2305efaaa0bbca5bd59881c5e246e7894bc5043

Fixes: #10770

Because other sections need to read the up-to-date data that is updated by scroll section, we need to set its z-index to a higher value.

Issue: AutoFill marker section drawing lags behind while scrolling.

Also refactored some of the things in the file, without changing the logic.

Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: Ia2305efaaa0bbca5bd59881c5e246e7894bc5043
@eszkadev
Copy link
Contributor

eszkadev commented Jan 9, 2025

@gokaysatir it's RED now, do we want ot include this?

@gokaysatir
Copy link
Contributor Author

@gokaysatir it's RED now, do we want ot include this?

Yes i guess we can have it in. This is bound to 2 different issues.

Copy link
Contributor

@eszkadev eszkadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, fixes the issue with "auto fill marker" no in sync while scrolling/zooming

@gokaysatir gokaysatir merged commit 4e78af8 into master Jan 9, 2025
14 checks passed
@gokaysatir gokaysatir deleted the private/gokay/section-drawing-orders branch January 9, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cell handle appears offset while scrolling in Calc
2 participants