Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev_notes: added notes for locale decimal separators #11015

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

lpranam
Copy link
Member

@lpranam lpranam commented Jan 24, 2025

Change-Id: I69bdb5de8a51ef04e15dcb3696a48855472b19b8

  • Target version: master

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@lpranam lpranam requested a review from caolanm January 24, 2025 14:55
@caolanm
Copy link
Contributor

caolanm commented Jan 24, 2025

Looks like the sort of thing we want, but move it a dir higher I think, stick "dev-notes" into the root dir. If you think there should be a browser subdir, then dev-notes/browser/whatever, but just dev-notes/locale.md is probably fine. If we have lots of stuff, then we can put into subdirs of dev-notes afterwards I support.

Signed-off-by: Pranam Lashkari <[email protected]>
Change-Id: I69bdb5de8a51ef04e15dcb3696a48855472b19b8
@lpranam lpranam changed the title dev_notes: added notes for locale Decimal separators dev_notes: added notes for locale decimal separators Jan 24, 2025
Copy link
Contributor

@caolanm caolanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I think we can skip ci for docs

@caolanm caolanm merged commit 1c05e7a into CollaboraOnline:master Jan 24, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants