Skip to content

[CRIT] Upgrade to .NET 9 #1065

[CRIT] Upgrade to .NET 9

[CRIT] Upgrade to .NET 9 #1065

Triggered via pull request September 22, 2024 08:42
@neon-nyanneon-nyan
synchronize #577
net-9
Status Success
Total duration 5m 46s
Artifacts 1

build.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

206 warnings
build (Release, x64, net9.0-windows10.0.22621.0): Hi3Helper.Http/Legacy/Session/SessionManager.cs#L92
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net9.0-windows10.0.22621.0): Hi3Helper.Http/Legacy/Session/SessionManager.cs#L201
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net9.0-windows10.0.22621.0): Hi3Helper.Http/Legacy/Session/SessionManager.cs#L236
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net9.0-windows10.0.22621.0): Hi3Helper.Http/Legacy/Session/SessionMerge.cs#L29
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net9.0-windows10.0.22621.0): H.NotifyIcon/src/libs/H.GeneratedIcons.System.Drawing/SystemDrawingIconGenerator.cs#L73
Populate switch (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0010)
build (Release, x64, net9.0-windows10.0.22621.0): H.NotifyIcon/src/libs/H.GeneratedIcons.System.Drawing/SystemDrawingIconGenerator.cs#L99
Populate switch (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0010)
build (Release, x64, net9.0-windows10.0.22621.0): Hi3Helper.CommunityToolkit/ImageCropper/obj/x64/Release/net9.0-windows10.0.22621.0/win-x64/XamlTypeInfo.g.cs#L256
Unrecognized value passed to the parameter 'type' of method 'System.Runtime.CompilerServices.RuntimeHelpers.RunClassConstructor(RuntimeTypeHandle)'. It's not possible to guarantee the availability of the target static constructor.
build (Release, x64, net9.0-windows10.0.22621.0): H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenu.cs#L17
Collection initialization can be simplified (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0028)
build (Release, x64, net9.0-windows10.0.22621.0): H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs#L55
Populate switch (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0010)
build (Release, x64, net9.0-windows10.0.22621.0): H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenu.cs#L66
Remove redundant equality (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0100)
Access to a static member of a type via a derived type: CollapseLauncher/XAMLs/Updater/Classes/Updater.cs#L75
Access to a static member of a type via a derived type
Possible 'null' assignment to non-nullable entity: CollapseLauncher/Program.cs#L261
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity: CollapseLauncher/Program.cs#L292
Possible 'null' assignment to non-nullable entity
Incorrect indent (around child statement): Hi3Helper.CommunityToolkit/ImageCropper/ImageCropper.Helpers.cs#L67
Line is not indented relative to the previous line around child statement, expected indent 4 spaces
Equality comparison of floating point numbers: Hi3Helper.CommunityToolkit/ImageCropper/ImageCropper.cs#L459
Equality comparison of floating point numbers. Possible loss of precision while rounding values
Conditional access qualifier expression is not null according to nullable reference types' annotations: H.NotifyIcon/src/libs/H.NotifyIcon/Core/TrayIcon.cs#L220
Conditional access qualifier expression is never null according to nullable reference types' annotations
Conditional access qualifier expression is not null according to nullable reference types' annotations: CollapseLauncher/Classes/Helper/LauncherApiLoader/Sophon/LauncherGameNews.cs#L87
Conditional access qualifier expression is never null according to nullable reference types' annotations
Conditional access qualifier expression is not null according to nullable reference types' annotations: CollapseLauncher/Classes/Helper/LauncherApiLoader/Sophon/LauncherGameNews.cs#L132
Conditional access qualifier expression is never null according to nullable reference types' annotations
Conditional access qualifier expression is not null according to nullable reference types' annotations: CollapseLauncher/Classes/Helper/LauncherApiLoader/Sophon/LauncherGameNews.cs#L109
Conditional access qualifier expression is never null according to nullable reference types' annotations
Use null check pattern instead of a type check succeeding on any not-null value: Hi3Helper.CommunityToolkit/ImageCropper/ImageBlendBrush.cs#L134
Use not null pattern instead of a type check succeeding on any not-null value
Usage of <inheritdoc /> is invalid: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs#L32
Usage of is invalid: No base candidate to inherit from
Usage of <inheritdoc /> is invalid: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenu.cs#L10
Usage of is invalid: No base candidate to inherit from
Usage of <inheritdoc /> is invalid: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs#L18
Usage of is invalid: No base candidate to inherit from
Usage of <inheritdoc /> is invalid: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupSubMenu.cs#L16
Usage of is invalid: No base candidate to inherit from
Usage of <inheritdoc /> is invalid: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs#L24
Usage of is invalid: No base candidate to inherit from
Usage of <inheritdoc /> is invalid: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs#L29
Usage of is invalid: No base candidate to inherit from
Usage of <inheritdoc /> is invalid: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs#L21
Usage of is invalid: No base candidate to inherit from
Usage of <inheritdoc /> is invalid: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs#L35
Usage of is invalid: No base candidate to inherit from
Usage of <inheritdoc /> is invalid: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupSubMenu.cs#L19
Usage of is invalid: No base candidate to inherit from
Local function hides method: CollapseLauncher/Classes/RegionManagement/FallbackCDNUtil.cs#L441
Local function 'HttpInstance_DownloadProgressAdapter' hides method 'void CollapseLauncher.FallbackCDNUtil.HttpInstance_DownloadProgressAdapter(object, DownloadEvent)'
Local function hides method: CollapseLauncher/Classes/RegionManagement/FallbackCDNUtil.cs#L492
Local function 'HttpInstance_DownloadProgressAdapter' hides method 'void CollapseLauncher.FallbackCDNUtil.HttpInstance_DownloadProgressAdapter(object, DownloadEvent)'
Non-accessed field (private accessibility): CollapseLauncher/XAMLs/MainApp/MainPage.xaml#L23
Field 'MediaPlayerFrame' is assigned but its value is never used
'??' condition is never null according to nullable reference types' annotations: H.NotifyIcon/src/libs/H.NotifyIcon.Shared/TaskbarIcon.ToolTips.cs#L141
'??' left operand is never null according to nullable reference types' annotations
Assignment is not used: Hi3Helper.CommunityToolkit/ImageCropper/ImageCropper.Helpers.cs#L57
Value assigned is not used in any execution path
Redundant 'IEnumerable.Cast<T>' or 'IEnumerable.OfType<T>' call: CollapseLauncher/App.xaml.cs#L151
Redundant 'IEnumerable.OfType' call. Consider comparing with 'null' instead.
Redundant 'IEnumerable.Cast<T>' or 'IEnumerable.OfType<T>' call: CollapseLauncher/App.xaml.cs#L158
Redundant 'IEnumerable.OfType' call. Consider comparing with 'null' instead.
Redundant using directive: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenu.cs#L2
Using directive is not required by the code and can be safely removed
Redundant using directive: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenu.cs#L1
Using directive is not required by the code and can be safely removed
Redundant using directive: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenu.cs#L3
Using directive is not required by the code and can be safely removed
Redundant using directive: H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenu.cs#L4
Using directive is not required by the code and can be safely removed
Redundant using directive: CollapseLauncher/Program.cs#L29
Using directive is not required by the code and can be safely removed
Redundant using directive: CollapseLauncher/Classes/Helper/Image/ImageLoaderHelper.cs#L9
Using directive is not required by the code and can be safely removed
Unused local variable: CollapseLauncher/Classes/Helper/TaskSchedulerHelper.cs#L37
Local variable 'currentExecPath' is never used
Usage of default struct equality: CollapseLauncher/Classes/InstallManagement/BaseClass/InstallManagerBase.cs#L3226
Struct 'GameVersion' is checked for equality using the inefficient runtime-provided implementation
Do not use object initializer for 'using' variable: CollapseLauncher/Classes/Helper/TaskSchedulerHelper.cs#L179
Initialize object properties inside the 'using' statement to ensure that the object is disposed if an exception is thrown during initialization
Variable can be declared as non-nullable: CollapseLauncher/Classes/RepairManagement/Honkai/Fetch.cs#L606
'tempXMFMetaStream' can be declared as non-nullable
Grid element column/row index is out of grid definition range: CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml#L278
Column index 1 is out of grid column definitions range (0-0)
Grid element column/row index is out of grid definition range: CollapseLauncher/XAMLs/MainApp/MainPage.xaml#L471
Column index 2 is out of grid column definitions range (0-1)
Grid element column/row index is out of grid definition range: CollapseLauncher/XAMLs/MainApp/MainPage.xaml#L104
Column index 0 with span 7 is out of grid column definitions range (0-0)
Path error: Hi3Helper.CommunityToolkit/SettingsControls/Themes/Generic.xaml#L5
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/SettingsControls/Hi3Helper.CommunityToolkit.WinUI.Controls.SettingsControls' is not found
Path error: Hi3Helper.CommunityToolkit/ImageCropper/Themes/Generic.xaml#L6
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/ImageCropper/Hi3Helper.CommunityToolkit.WinUI.Controls.ImageCropper/ImageCropper.xaml' is not found
Path error: Hi3Helper.CommunityToolkit/SettingsControls/SettingsExpander/SettingsExpander.xaml#L11
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/SettingsControls/Hi3Helper.CommunityToolkit.WinUI.Controls.SettingsControls' is not found
Path error: Hi3Helper.CommunityToolkit/ImageCropper/Themes/Generic.xaml#L6
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/ImageCropper/Hi3Helper.CommunityToolkit.WinUI.Controls.ImageCropper' is not found
Path error: Hi3Helper.CommunityToolkit/SettingsControls/Themes/Generic.xaml#L5
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/SettingsControls/Hi3Helper.CommunityToolkit.WinUI.Controls.SettingsControls/SettingsExpander/SettingsExpander.xaml' is not found
Path error: Hi3Helper.CommunityToolkit/SettingsControls/Themes/Generic.xaml#L4
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/SettingsControls/Hi3Helper.CommunityToolkit.WinUI.Controls.SettingsControls/SettingsCard/SettingsCard.xaml' is not found
Path error: Hi3Helper.CommunityToolkit/SettingsControls/Themes/Generic.xaml#L5
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/SettingsControls/Hi3Helper.CommunityToolkit.WinUI.Controls.SettingsControls/SettingsExpander' is not found
Path error: Hi3Helper.CommunityToolkit/ImageCropper/Themes/Generic.xaml#L7
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/ImageCropper/Hi3Helper.CommunityToolkit.WinUI.Controls.ImageCropper' is not found
Path error: Hi3Helper.CommunityToolkit/SettingsControls/Themes/Generic.xaml#L4
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/SettingsControls/Hi3Helper.CommunityToolkit.WinUI.Controls.SettingsControls' is not found
Path error: Hi3Helper.CommunityToolkit/ImageCropper/Themes/Generic.xaml#L7
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/ImageCropper/Hi3Helper.CommunityToolkit.WinUI.Controls.ImageCropper/ImageCropperThumb.xaml' is not found
Path error: Hi3Helper.CommunityToolkit/SettingsControls/SettingsExpander/SettingsExpander.xaml#L11
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/SettingsControls/Hi3Helper.CommunityToolkit.WinUI.Controls.SettingsControls/SettingsCard' is not found
Path error: Hi3Helper.CommunityToolkit/SettingsControls/Themes/Generic.xaml#L4
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/SettingsControls/Hi3Helper.CommunityToolkit.WinUI.Controls.SettingsControls/SettingsCard' is not found
Path error: Hi3Helper.CommunityToolkit/SettingsControls/SettingsExpander/SettingsExpander.xaml#L11
Path '$PROJECT_DIR$/Hi3Helper.CommunityToolkit/SettingsControls/Hi3Helper.CommunityToolkit.WinUI.Controls.SettingsControls/SettingsCard/SettingsCard.xaml' is not found
Remove redundant attached property setter: CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml#L1038
Attached property setter 'Grid.Column' has no effect in the current context and can be removed
Remove redundant attached property setter: CollapseLauncher/XAMLs/MainApp/MainPage.xaml#L399
Attached property setter 'Grid.ColumnSpan' has no effect in the current context and can be removed
Remove redundant attached property setter: CollapseLauncher/XAMLs/MainApp/Pages/CachesPage.xaml#L126
Attached property setter 'Grid.Row' has no effect in the current context and can be removed
Remove redundant attached property setter: CollapseLauncher/XAMLs/MainApp/MainPage.xaml#L398
Attached property setter 'Grid.Column' has no effect in the current context and can be removed
Remove redundant attached property setter: CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml#L1318
Attached property setter 'Grid.Column' has no effect in the current context and can be removed
Remove redundant attached property setter: Hi3Helper.CommunityToolkit/SettingsControls/SettingsCard/SettingsCard.xaml#L404
Attached property setter 'Grid.Column' has no effect in the current context and can be removed
Redundant namespace alias: CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml#L13
Namespace alias 'hypTypes' is not required by code and can be safely removed
Redundant namespace alias: Hi3Helper.CommunityToolkit/ImageCropper/Themes/Generic.xaml#L3
Namespace alias 'controls' is not required by code and can be safely removed
Redundant namespace alias: Hi3Helper.CommunityToolkit/ImageCropper/ImageCropper.xaml#L4
Namespace alias 'ui' is not required by code and can be safely removed
Redundant resource: CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml#L434
Resource 'BooleanToVisibilityConverter' is never used
Redundant resource: CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml#L34
Resource 'BooleanVisibilityConverter' is never used
Property value is equal to style-provided: CollapseLauncher/XAMLs/MainApp/MainPage.xaml#L347
Equal value provided by style 'AcrylicButtonStyle'

Artifacts

Produced during runtime
Name Size
collapse_x64-Release_net9.0-windows10.0.22621.0_c65b098d7d66f860c2b4bfe52d1325937bb7983c
114 MB