Skip to content

[CRIT] Upgrade to .NET 9 #1067

[CRIT] Upgrade to .NET 9

[CRIT] Upgrade to .NET 9 #1067

GitHub Actions / Qodana for .NET completed Sep 22, 2024 in 0s

100 new problems found by Qodana for .NET

Qodana for .NET

100 new problems were found

Inspection name Severity Problems
XAML Errors 🔴 Failure 1
Path error 🔶 Warning 13
Redundant cast 🔶 Warning 11
Usage of <inheritdoc /> is invalid 🔶 Warning 10
Redundant 'partial' modifier on type declaration 🔶 Warning 7
Redundant name qualifier 🔶 Warning 7
Unused parameter in partial method 🔶 Warning 5
Expression is always 'true' or always 'false' 🔶 Warning 4
Redundant using directive 🔶 Warning 4
Unused local variable 🔶 Warning 4
Redundant namespace alias 🔶 Warning 4
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 3
Redundant class or interface specification in base types list 🔶 Warning 3
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 2
Invalid XML documentation comment 🔶 Warning 2
Cannot resolve symbol in text argument 🔶 Warning 2
Redundant empty switch section 🔶 Warning 2
Get-only auto-property is never assigned 🔶 Warning 2
Remove redundant attached property setter 🔶 Warning 2
Access to a static member of a type via a derived type 🔶 Warning 1
Possible 'null' assignment to non-nullable entity 🔶 Warning 1
Incorrect indent (around child statement) 🔶 Warning 1
Equality comparison of floating point numbers 🔶 Warning 1
Use null check pattern instead of a type check succeeding on any not-null value 🔶 Warning 1
Return value of [MustUseReturnValue] annotated method is not used 🔶 Warning 1
'??' condition is never null according to nullable reference types' annotations 🔶 Warning 1
Possible unassigned object created by 'new' expression 🔶 Warning 1
Assignment is not used 🔶 Warning 1
Redundant base constructor call 🔶 Warning 1
Redundant boolean comparison 🔶 Warning 1
Unsafe context declaration is redundant 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 94 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.BindingHelper.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 284 in CollapseLauncher/Program.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 67 in Hi3Helper.CommunityToolkit/ImageCropper/ImageCropper.Helpers.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Incorrect indent (around child statement)

Line is not indented relative to the previous line around child statement, expected indent 4 spaces

Check warning on line 459 in Hi3Helper.CommunityToolkit/ImageCropper/ImageCropper.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Equality comparison of floating point numbers

Equality comparison of floating point numbers. Possible loss of precision while rounding values

Check warning on line 669 in CollapseLauncher/Classes/RepairManagement/Honkai/Fetch.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Expression is always 'true' or always 'false'

Expression is always true

Check warning on line 674 in CollapseLauncher/Classes/RepairManagement/Honkai/Fetch.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Expression is always 'true' or always 'false'

Expression is always true

Check warning on line 655 in CollapseLauncher/Classes/RepairManagement/Honkai/Fetch.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Expression is always 'true' or always 'false'

Expression is always true

Check warning on line 53 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.BindingHelper.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Expression is always 'true' or always 'false'

Expression is always false

Check warning on line 276 in Hi3Helper.CommunityToolkit/SettingsControls/SettingsCard/SettingsCard.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Expression is always 'true' or 'false' according to nullable reference types' annotations

Expression is always true according to nullable reference types' annotations

Check warning on line 134 in Hi3Helper.CommunityToolkit/ImageCropper/ImageBlendBrush.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Expression is always 'true' or 'false' according to nullable reference types' annotations

Expression is always true according to nullable reference types' annotations

Check warning on line 300 in Hi3Helper.CommunityToolkit/SettingsControls/SettingsCard/SettingsCard.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Expression is always 'true' or 'false' according to nullable reference types' annotations

Expression is always false according to nullable reference types' annotations

Check warning on line 34 in H.NotifyIcon/src/libs/H.NotifyIcon.Shared/GeneratedIconSource.System.Drawing.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is not null according to nullable reference types' annotations

Conditional access qualifier expression is never null according to nullable reference types' annotations

Check warning on line 220 in H.NotifyIcon/src/libs/H.NotifyIcon/Core/TrayIcon.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is not null according to nullable reference types' annotations

Conditional access qualifier expression is never null according to nullable reference types' annotations

Check warning on line 134 in Hi3Helper.CommunityToolkit/ImageCropper/ImageBlendBrush.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use null check pattern instead of a type check succeeding on any not-null value

Use not null pattern instead of a type check succeeding on any not-null value

Check warning on line 32 in H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Usage of <inheritdoc /> is invalid

Usage of is invalid: No base candidate to inherit from

Check warning on line 10 in H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenu.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Usage of <inheritdoc /> is invalid

Usage of is invalid: No base candidate to inherit from

Check warning on line 18 in H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Usage of <inheritdoc /> is invalid

Usage of is invalid: No base candidate to inherit from

Check warning on line 16 in H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupSubMenu.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Usage of <inheritdoc /> is invalid

Usage of is invalid: No base candidate to inherit from

Check warning on line 24 in H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Usage of <inheritdoc /> is invalid

Usage of is invalid: No base candidate to inherit from

Check warning on line 29 in H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Usage of <inheritdoc /> is invalid

Usage of is invalid: No base candidate to inherit from

Check warning on line 36 in H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/TrayIconWithContextMenu.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Usage of <inheritdoc /> is invalid

Usage of is invalid: No base candidate to inherit from

Check warning on line 21 in H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Usage of <inheritdoc /> is invalid

Usage of is invalid: No base candidate to inherit from

Check warning on line 35 in H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupMenuItem.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Usage of <inheritdoc /> is invalid

Usage of is invalid: No base candidate to inherit from

Check warning on line 19 in H.NotifyIcon/src/libs/H.NotifyIcon/PopupMenus/PopupSubMenu.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Usage of <inheritdoc /> is invalid

Usage of is invalid: No base candidate to inherit from

Check warning on line 36 in Hi3Helper.CommunityToolkit/ImageCropper/ImageBlendBrush.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Invalid XML documentation comment

Cannot resolve symbol 'Source'