On quitting pomodoro mode, output total time spent working and resting #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looked good, however that [Duration; 2] could have been better named |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I implemented the request from #15 , specifically the second version proposed there: after the timer is closed, the pomodoro mode optionally displays the total time spent working and on break, respectively.
It measures the time during which the pomodoro timer advances, i.e. excess time is counted, skips and pauses are not counted (neither the time spent in the skip ui-mode).
To use it, invoke it with th '-e' flag, e.g. "porsmo pomodoro -e short"; I was unfamiliar with clap before today, this what I came up with, although I am not overly happy with it.
(This is my first ever pull request to a public repo; feel free to tell me where I could do better.)