-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major Fix from branches [0008, 0014, 0018, 0019, 0020] #25
Conversation
… are getting resolved
capture_gui/plugins/timeplugin.py
Outdated
@@ -61,6 +74,56 @@ def _ensure_start(self, value): | |||
def _ensure_end(self, value): | |||
self.end.setValue(max(self.end.value(), value)) | |||
|
|||
def parse_frames(self, string): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take this method out of the class and turn it into a function so the logic stays separate, especially because it's not using anything from the instance. It's only a simple algorithm.
@aardschok Should we also add a validate method for the TimePlugin when it is in the custom frames mode. That way as one types it could directly "confirm" whether the current text can be parsed correctly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aardschok Great example for registering the preset. I think we can improve it slightly. I think the title can be Register preset paths so it's corresponding more with the terminology used in the package.
I also believe the example is simple enough to do with less comments overall, that's great! For example, I believe this already covers what we're trying to explain:
Register preset paths
Register a preset path that will be used by the capture gui to load default presets from.
import capture_gui.presets
import capture_gui
path = "path/to/directory"
capture_gui.presets.register_path(path)
# After registering capture gui will automatically load
# the presets found in all registered preset paths
capture_gui.main()
What do you think?
Fixed :