Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added displayLights menu #55

Merged
merged 10 commits into from
May 11, 2017
Merged

Added displayLights menu #55

merged 10 commits into from
May 11, 2017

Conversation

aardschok
Copy link
Contributor

Additions

  • Implemented lighting menu, pick type of display lighting for playblast

Changes

  • Restructured UI for Viewport Plugin

BigRoy
BigRoy reviewed May 11, 2017
View reviewed changes
capture_gui/plugins/viewportplugin.py Outdated
self.show_type_actions = list()
self.show_types = lib.get_show_object_types()
self.display_lights_acitons = list()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in actions

@BigRoy
Copy link
Member

BigRoy commented May 11, 2017

Should this also implement two sided lighting and shadows toggle? :)
Again, that is also a question related to #53 discussion.

@aardschok
Copy link
Contributor Author

aardschok commented May 11, 2017 •
edited
Loading

"Fixed issue with two sided lighting and shadows being checkboxes" should be:
"Fixed issue with two sided lighting and shadows not being checkboxes". They needed to be accessible regardless of the type of lighting chosen, see Lighting menu in Maya viewport

@aardschok
Copy link
Contributor Author

Fix #52

@BigRoy BigRoy merged commit 5ddfd0d into Colorbleed:master May 11, 2017
This was referenced May 11, 2017
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aardschok @BigRoy