Implement Email Creation Request Feature for New Interns #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akshiteshnaithani
changed the base branch from
master
to
feature/working-staff-management
…ature/3267/Send-email-to-Infra-team
Passing run #7408 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
…/coloredcow/portal into feature/3267/Send-email-to-Infra-team
Akshiteshnaithani
changed the base branch from
feature/working-staff-management
to
feature/onboarding-of-new-joinee-via-gsheet
…/github.com/coloredcow/portal into feature/3267/Send-email-to-Infra-team
Akshiteshnaithani
added
the
status : ready for review
Bahugunajii
suggested changes
Jul 11, 2023
| { | ||
| return $this->from(config('mail.from.address'), config('mail.from.name')) | ||
| ->subject('Subject: Request for Email Creation ' . $this->data['name']) | ||
| ->to('[email protected]') |
There was a problem hiding this comment.
let's fetch this mail from config
There was a problem hiding this comment.
I think we don't require this file
Comment on lines
2
to
6
| <style> | ||
| .line { | ||
| line-height: 1px; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Let's avoid using br tag. Instead of it, we can add a custom class here something like
Suggested change
| <style> | |
| .line { | |
| line-height: 1px; | |
| } | |
| </style> | |
| <style> | |
| .line { | |
| line-height: 1px; | |
| }, | |
| .margin-bottom { | |
| margin-bottom: 40px; | |
| } | |
| </style> |
| <p>If there are any specific forms or documentation required for this process, kindly let me know, and I will | ||
| promptly provide the necessary information.</p> | ||
| <br> | ||
| <p>Thank you for your prompt attention to this matter. Your assistance is greatly appreciated. |
There was a problem hiding this comment.
and use the above class here as:
Suggested change
| <p>Thank you for your prompt attention to this matter. Your assistance is greatly appreciated. | |
| <p class="margin-bottom>Thank you for your prompt attention to this matter. Your assistance is greatly appreciated. |
Bahugunajii
suggested changes
Jul 11, 2023
| <p>Thank you for your prompt attention to this matter. Your assistance is greatly appreciated. | ||
| Best regards,</p> | ||
| <p class="line">Best regards,</p> | ||
| <p class="line mt-4">Mohit Sharma</p> |
There was a problem hiding this comment.
Suggested change
| <p class="line mt-4">Mohit Sharma</p> | |
| <p class="line">Mohit Sharma</p> |
Bahugunajii
suggested changes
Jul 13, 2023
Modules/HR/Config/config.php
Outdated
| @@ -204,6 +204,7 @@ | |||
| 'primary' => env('HR_FOLLOWUP_EMAIL_PRIMARY', '[email protected]'), | |||
| 'secondary' => env('HR_FOLLOWUP_EMAIL_SECONDARY', '[email protected]'), | |||
| ], | |||
| 'hr-infra-mail' => '[email protected]', | |||
There was a problem hiding this comment.
Suggested change
| 'hr-infra-mail' => '[email protected]', | |
| 'hr-infra-mail' => env('INFRA_SUPPORT_EMAIL', '[email protected]'), |
Bahugunajii
approved these changes
Jul 13, 2023
Bahugunajii
merged commit 7a16b8a
into
feature/onboarding-of-new-joinee-via-gsheet
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #3267
Description
Ending email requests to the Infra team for creating email accounts for new interns.
Checklist: