Contractor appraisal letter #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage report for commit: 0e58dd8 Summary - Lines: 2.96% | Methods: 5.35%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3687 +/- ##
========================================
Coverage 3.37% 3.37%
Complexity 595 595
========================================
Files 106 106
Lines 2133 2133
========================================
Hits 72 72
Misses 2061 2061 ☔ View full report in Codecov by Sentry. |
srivastava-jyoti
changed the base branch from
master
to
feature/intern-contractor-appraisal
Comment on lines
217
to
225
| public function getEmployeeAge($employee) | ||
| { | ||
| $user = $employee->user; | ||
| $userProfile = $user->profile; | ||
| $dateOfBirth = $userProfile->date_of_birth; | ||
| $dob = Carbon::parse($dateOfBirth); | ||
| $age = $dob->age; | ||
| return $age; | ||
| } |
There was a problem hiding this comment.
Can you make this an accessor in user Model. So that we can get the age attribute everywhere by using $user->age
srivastava-jyoti
merged commit 16adc2e
into
feature/intern-contractor-appraisal
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #ISSUE_ID
Description of the changes
Breakdown & Estimates
Expected Time Range:
Actual Time:
Feedback Cycle
Cycle Count: 0
Checklist: