Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail safe error handling #21

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Fail safe error handling #21

merged 5 commits into from
Apr 10, 2024

Conversation

samyakkkk
Copy link
Contributor

Two possible failure places are:

CLI throws exception during processing

  • Added try/catch over each task execution that sends a error message to IDE.
  • Errors that couldn't be linked to a task, say failure while parsing IncomingMessage are reported back as global errors to the IDE.

IDE fails to return required data.

  • If IDE doesn't have handler for any of the fetch requests, it will send back an error response. CLI will then handle the case or throw an error.
  • Introduced TimeoutKind, that limits the time it should take for IDE to process fetch requests. It has 3 options, 6s, 60s, 6 mins.

The counterpart IDE PR will be linked in comments.

@samyakkkk
Copy link
Contributor Author

IDE PR: CommandDash/commanddash#247

@samyakkkk samyakkkk mentioned this pull request Apr 8, 2024
Closed
@KevalPrajapati KevalPrajapati merged commit 04d63c6 into develop Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevalPrajapati KevalPrajapati Awaiting requested review from KevalPrajapati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samyakkkk @KevalPrajapati