Feature/megafon #44
Open
Feature/megafon #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now manage with ObjectProfileLink
| @@ -41,7 +41,7 @@ class ObjectProfileLink(models.Model): | |||
|
|
|||
| @receiver(post_save, sender=User) | |||
| def create_profile_on_user_signup(sender, created, instance, **kwargs): | |||
| if created: | |||
| if created and not instance.is_superuser: | |||
There was a problem hiding this comment.
ça me semble OK, mais je me demande juste ce qui rend cet ajout nécessaire ?
|
@atiberghien ça me semble putot cool après une 2e lecture du code; j'ai pas plus de recul que ça sur MPTT, mais j'aime bien le fait de coder Questions et Réponses avec le mème modèle (Post) et c''est cool de voir qu'on réutilise aussi les autres briques (ObjectProfileLink). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@atiberghien je crée ce PR pour pouvoir discuter dessus