Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with tint not applying to loaded images #2077

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix issue with tint not applying to loaded images #2077

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1ef6a7d
Set image source if not matching element source, allow tint to apply …
myix765 Jul 31, 2024
586f28d
Remove check for image loaded which caused issue with ToggleImageSour…
myix765 Jul 31, 2024
5857a4e
Add check back for IsLoaded, edit check for if image is not ready to …
myix765 Jul 31, 2024
25b934d
Reset copying over TryGetButtonImage change
myix765 Jul 31, 2024
70dc76d
Merge branch 'main' into tint-navigate-bug
myix765 Jul 31, 2024
934880c
Changed location of matching source check
myix765 Aug 1, 2024
b25318f
Merge branch 'main' into tint-navigate-bug
myix765 Aug 1, 2024
45570cf
Merge branch 'main' into tint-navigate-bug
bijington Sep 23, 2024
868faab
Add `OnIconTintColorBehaviorPropertyChanged`
brminnick Sep 23, 2024
12fa1ae
Update IconTintColorBehavior.windows.cs
brminnick Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...tyToolkit.Maui/Behaviors/PlatformBehaviors/IconTintColor/IconTintColorBehavior.windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,14 @@ void ApplyTintColor(FrameworkElement platformView, View element, Color? color)

void LoadAndApplyImageTintColor(View element, WImage image, Color color)
{
if (element is IImageElement { Source: UriImageSource uriImageSource })
// Sometimes WImage source doesn't match View source so the image is not ready to be tinted, have to wait for next ImageOpened event
if (element is IImageElement { Source: FileImageSource fileImageSource } &&
image.Source is BitmapImage bitmapImage &&
myix765 marked this conversation as resolved.
Show resolved Hide resolved
Uri.Compare(new Uri($"{bitmapImage.UriSource.Scheme}:///{fileImageSource.File}"), bitmapImage.UriSource, UriComponents.Path, UriFormat.Unescaped, StringComparison.OrdinalIgnoreCase) != 0)
{
image.ImageOpened += OnImageOpened;
}
else if (element is IImageElement { Source: UriImageSource uriImageSource })
{
image.Source = Path.GetExtension(uriImageSource.Uri.AbsolutePath) switch
{
Expand All @@ -140,6 +147,10 @@ void LoadAndApplyImageTintColor(View element, WImage image, Color color)

ApplyTintColor();
}
else if (image.IsLoaded)
{
ApplyTintColor();
}
else
{
image.ImageOpened += OnImageOpened;
Expand Down