Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Multiple Windows on MacOS #2260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ne0rrmatrix
Copy link
Contributor

@ne0rrmatrix ne0rrmatrix commented Oct 5, 2024

  • Bug fix

Description of Change

Add support for more than one window on MacOS. With this PR Media Element will now show multiple windows when you visit the Multi-Window Page on MacOS.

Linked Issues

PR Checklist

Additional information

With this PR MacOS will fully support multiple windows on MacOS when using Media Element. Documentation will need updating to add the changes to Manifest file for MacOS.

@ne0rrmatrix ne0rrmatrix self-assigned this Oct 5, 2024
@ne0rrmatrix ne0rrmatrix added the 📽️ MediaElement Issue/PR that has to do with MediaElement label Oct 5, 2024
@brminnick
Copy link
Collaborator

Nice! Could you open a Docs PR to add this info to the MediaElement Platform Specific Initialization section before we merge this PR?

https://learn.microsoft.com/en-us/dotnet/communitytoolkit/maui/views/mediaelement?tabs=mac#platform-specific-initialization

@ne0rrmatrix
Copy link
Contributor Author

Nice! Could you open a Docs PR to add this info to the MediaElement Platform Specific Initialization section before we merge this PR?

https://learn.microsoft.com/en-us/dotnet/communitytoolkit/maui/views/mediaelement?tabs=mac#platform-specific-initialization

Yes I will do that now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📽️ MediaElement Issue/PR that has to do with MediaElement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MediaElement not supported in a DataTemplate on MacCatalyst in an application using multiple windows
2 participants