Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Added symbols to XamlApplication package. #293

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Added symbols to XamlApplication package. #293

wants to merge 1 commit into from

Conversation

azchohfi
Copy link
Contributor

Fixes #292

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Build or CI related changes

What is the current behavior?

No symbols at all for the Microsoft.Toolkit.Win32.UI.XamlApplication package.

What is the new behavior?

Stripped and added symbols for the Microsoft.Toolkit.Win32.UI.XamlApplication package.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Oct 23, 2020

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned michael-hawker Oct 23, 2020
@ocalvo
Copy link
Contributor

ocalvo commented Oct 28, 2020

Can you make sure that the Xaml Islands repo still builds and that MSIX can still be compiled and run after this change?

@michael-hawker
Copy link
Member

@azchohfi is there anything left before we merge this?

@azchohfi
Copy link
Contributor Author

Do not merge! This was not working.

@michael-hawker michael-hawker marked this pull request as draft November 18, 2020 22:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No symbols on XamlApplication package
3 participants