Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Windows 11 ListViewStyle #566

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

TopperDEL
Copy link
Contributor

This PR copies the content from here over to 8.x, as the original issue is still valid.

Fixes

Fixes #327.

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The alternate row colors are only visible on hover.

What is the new behavior?

The alternate row colors are visible immediately.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

@TopperDEL
Copy link
Contributor Author

@dotnet-policy-service agree

@Arlodotexe Arlodotexe self-requested a review November 26, 2024 23:40
@Arlodotexe Arlodotexe merged commit 4fc769e into CommunityToolkit:main Nov 27, 2024
23 checks passed
@michael-hawker
Copy link
Member

@Arlodotexe just saw this, you test on both UWP and WASDK?

I am a bit worried about the call to FindDescendants as it is a heavier operation, though it should find the first child.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ListViewExtensions.AlternateColor only gets applied on hover
3 participants