Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more OE variants #12026

Merged
merged 3 commits into from
May 31, 2024
Merged

more OE variants #12026

merged 3 commits into from
May 31, 2024

Conversation

sarnold
Copy link
Contributor

@sarnold sarnold commented May 27, 2024

Description:

  • add common/useful OE distribution variants
  • add missing table transforms

Rationale:

  • distribution is a common customization

Review Hints:

  • each commit is small/logically distinct

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 27, 2024
Copy link

openshift-ci bot commented May 27, 2024

Hi @sarnold. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12026
This image was built from commit: 0026e11

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12026

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12026 make deploy-local

Copy link

codeclimate bot commented May 27, 2024

Code Climate has analyzed commit 0026e11 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I am not familiar with these distros. I will keep it here a little more so others can also take a look.

@marcusburghardt marcusburghardt added this to the 0.1.74 milestone May 28, 2024
@marcusburghardt marcusburghardt added CPE-AL CPE Applicability Language OpenEmbedded OpenEmbedded Linux product related. labels May 28, 2024
@sarnold
Copy link
Contributor Author

sarnold commented May 29, 2024

  • "petalinux" is a custom distro used in the xilinx/zynq SDK
  • "harden" is the name of an example distro layer provided by meta-security called meta-hardening

The first one is used for pretty much all zynq boards, and it seemed like a good thing if the second one was recognized by the scanner. Thanks!

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Mab879 Mab879 merged commit bb93187 into ComplianceAsCode:master May 31, 2024
107 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CPE-AL CPE Applicability Language needs-ok-to-test Used by openshift-ci bot. OpenEmbedded OpenEmbedded Linux product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants