Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "OCP4: Support multi-arch content image" #12064

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jun 14, 2024

Description:

This reverts commit 140fed8.
This commit is causing CI fail.

Rationale:

Reverting to keep CI green from known failures.

PR #12055 doesn't seem to work. It causing master to always be red.

Review Hints:

Review the CI failing on master, see that this commit seems to be the cause.

This reverts commit 140fed8.
This commit is causing CI fail. Reverting to keep CI green
from known failures.
@Mab879
Copy link
Member Author

Mab879 commented Jun 14, 2024

cc @lbragstad @yuumasato @Vincent056

If you have a better solution please let me know or propose a PR.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12064
This image was built from commit: e2a02e5

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12064

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12064 make deploy-local

Copy link

codeclimate bot commented Jun 14, 2024

Code Climate has analyzed commit e2a02e5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@yuumasato yuumasato self-assigned this Jun 14, 2024
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mab879.
Merging to unblock master.

@yuumasato yuumasato merged commit 9acfe41 into ComplianceAsCode:master Jun 14, 2024
89 of 91 checks passed
@Mab879 Mab879 deleted the revert_12055 branch June 14, 2024 15:46
@Mab879 Mab879 added this to the 0.1.74 milestone Jun 14, 2024
@Mab879 Mab879 added the Infrastructure Our content build system label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants