Various Bug Fixes for Debian #12084

a-skr · 2024-06-20T13:13:30Z

Description:

update debian12 profiles
update a chronyd rule to handle debian /etc sub-directories organization.
fix a regex in sysctl template

openshift-ci · 2024-06-20T13:13:41Z

Hi @a-skr. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

github-actions · 2024-06-20T13:15:37Z

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

github-actions · 2024-06-20T13:19:45Z

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12084
This image was built from commit: ded9af2

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12084

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12084 make deploy-local

jan-cerny · 2024-06-25T07:16:00Z

linux_os/guide/services/ntp/chronyd_specify_remote_server/oval/shared.xml

@@ -15,7 +15,7 @@

  <ind:textfilecontent54_object comment="Ensure at least one NTP server is set"
  id="object_chronyd_remote_server" version="1">
-    <ind:filepath operation="pattern match">^/etc/chrony\.(conf|d/.+\.conf)$</ind:filepath>
+    <ind:filepath operation="pattern match">^/etc/(?:chrony/)?chrony\.(conf|d/.+\.conf)$</ind:filepath>


This needs to be reworked to use product properties chrony_conf_path and chrony_d_path correctly.

commit has been amended accordingly.

dodys · 2024-07-05T16:37:05Z

/packit build

jan-cerny · 2024-07-10T06:59:04Z

products/debian12/product.yml

+  chrony_conf_path: "/etc/chrony/chrony.conf"
+  chrony_d_path: "/etc/chrony/chrony.d"


the CI fails because you will have to update the product stability data

I have updated the product stability data (and rebased onto current master).

Mab879

Thanks for the PR, I have one comment.

Mab879 · 2024-07-17T19:31:10Z

linux_os/guide/services/ntp/chronyd_specify_remote_server/oval/shared.xml

@@ -15,7 +15,8 @@

  <ind:textfilecontent54_object comment="Ensure at least one NTP server is set"
  id="object_chronyd_remote_server" version="1">
-    <ind:filepath operation="pattern match">^/etc/chrony\.(conf|d/.+\.conf)$</ind:filepath>
+    <!-- ind:filepath operation="pattern match">^/etc/(?:chrony/)?chrony\.(conf|d/.+\.conf)$</ind:filepath -->


Dead code should be deleted, we can recover it in git if needed.

Sorry, I did miss this message from two weeks ago. I just updated my branch.

debian ships chrony configuration files under /etc/chrony/

codeclimate · 2024-08-01T16:12:37Z

Code Climate has analyzed commit ded9af2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

dodys

lgtm, thanks!

Mab879 · 2024-08-02T17:51:24Z

Automatus passes locally

$ ./automatus.py rule --datastream ../build/ssg-rhel9-ds.xml --remediate-using bash  --libvirt qemu:///system automatus_rhel9_4 chronyd_specify_remote_server 
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/mburket/Developer/ComplianceAsCode/content/tests/logs/rule-custom-2024-08-02-1247/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_chronyd_specify_remote_server
INFO - Script correct.pass.sh using profile (all) OK
INFO - Script correct_pool.pass.sh using profile (all) OK
INFO - Script file_empty.fail.sh using profile (all) OK
INFO - Script file_missing.fail.sh using profile (all) OK
INFO - Script line_missing.fail.sh using profile (all) OK
INFO - Script multiple_servers.pass.sh using profile (all) OK
INFO - Script server_not_specified.fail.sh using profile (all) OK

openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 20, 2024

a-skr mentioned this pull request Jun 20, 2024

regex error in sysctl template #12085

Open

jan-cerny reviewed Jun 25, 2024

View reviewed changes

marcusburghardt added the Debian Debian product related. label Jul 1, 2024

marcusburghardt requested a review from a team July 1, 2024 07:12

marcusburghardt added this to the 0.1.74 milestone Jul 1, 2024

a-skr force-pushed the fixes-debian branch from 0169fe6 to 161b206 Compare July 4, 2024 10:27

jan-cerny reviewed Jul 10, 2024

View reviewed changes

a-skr force-pushed the fixes-debian branch 2 times, most recently from eabac7d to 164b820 Compare July 16, 2024 07:38

Mab879 self-assigned this Jul 17, 2024

Mab879 requested changes Jul 25, 2024

View reviewed changes

Mab879 modified the milestones: 0.1.74, 0.1.75 Jul 29, 2024

a-skr added 4 commits August 1, 2024 17:14

update chronyd_specify_remote_server for debian

2408ab1

debian ships chrony configuration files under /etc/chrony/

update debian anssi profiles

806c539

fix regex in sysctl template

179699f

update debian12 product stability data

ded9af2

a-skr force-pushed the fixes-debian branch from 164b820 to ded9af2 Compare August 1, 2024 15:28

dodys approved these changes Aug 2, 2024

View reviewed changes

Mab879 approved these changes Aug 2, 2024

View reviewed changes

Mab879 merged commit 0c4f15e into ComplianceAsCode:master Aug 2, 2024
88 of 90 checks passed

yuumasato mentioned this pull request Aug 19, 2024

Fix chronyd remote server filepath dir regex #12312

Merged

Mab879 changed the title ~~Fixes debian~~ Various Bug Fixes for Debian Nov 14, 2024

Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various Bug Fixes for Debian #12084

Various Bug Fixes for Debian #12084

a-skr commented Jun 20, 2024

openshift-ci bot commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 20, 2024 •

edited

Loading

jan-cerny Jun 25, 2024

a-skr Jul 4, 2024

dodys commented Jul 5, 2024

jan-cerny Jul 10, 2024

a-skr Jul 11, 2024

Mab879 left a comment

Mab879 Jul 17, 2024

a-skr Aug 1, 2024

codeclimate bot commented Aug 1, 2024

dodys left a comment

Mab879 commented Aug 2, 2024

		chrony_conf_path: "/etc/chrony/chrony.conf"
		chrony_d_path: "/etc/chrony/chrony.d"

Various Bug Fixes for Debian #12084

Various Bug Fixes for Debian #12084

Conversation

a-skr commented Jun 20, 2024

Description:

openshift-ci bot commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 20, 2024 • edited Loading

jan-cerny Jun 25, 2024

Choose a reason for hiding this comment

a-skr Jul 4, 2024

Choose a reason for hiding this comment

dodys commented Jul 5, 2024

jan-cerny Jul 10, 2024

Choose a reason for hiding this comment

a-skr Jul 11, 2024

Choose a reason for hiding this comment

Mab879 left a comment

Choose a reason for hiding this comment

Mab879 Jul 17, 2024

Choose a reason for hiding this comment

a-skr Aug 1, 2024

Choose a reason for hiding this comment

codeclimate bot commented Aug 1, 2024

dodys left a comment

Choose a reason for hiding this comment

Mab879 commented Aug 2, 2024

github-actions bot commented Jun 20, 2024 •

edited

Loading