Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rules based on template pam_options to support SLE Micro #12335

Conversation

rumch-se
Copy link
Contributor

Description:

  • Some rules based on the template pam_options are updated to support SUSE SLE Micro STIG

Rationale:

  • The next rules need this update:
  • cracklib_accounts_password_pam_ucredit
  • cracklib_accounts_password_pam_lcredit
  • cracklib_accounts_password_pam_dcredit
  • cracklib_accounts_password_pam_difok
  • cracklib_accounts_password_pam_minlen
  • cracklib_accounts_password_pam_ocredit

Copy link

openshift-ci bot commented Aug 26, 2024

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 26, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Aug 26, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12335
This image was built from commit: 3270b5a

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12335

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12335 make deploy-local

@jan-cerny jan-cerny self-assigned this Aug 26, 2024
@jan-cerny jan-cerny added this to the 0.1.75 milestone Aug 26, 2024
@jan-cerny jan-cerny added the SLES SUSE Linux Enterprise Server product related. label Aug 26, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Aug 29, 2024
@jan-cerny
Copy link
Collaborator

@rumch-se please resolve the conflicting files

@teacup-on-rockingchair teacup-on-rockingchair force-pushed the pam_options_template_rules_update_slem branch from da98666 to 3270b5a Compare September 3, 2024 08:38
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Sep 3, 2024
Copy link

codeclimate bot commented Sep 3, 2024

Code Climate has analyzed commit 3270b5a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@teacup-on-rockingchair teacup-on-rockingchair merged commit 8df17e5 into ComplianceAsCode:master Sep 3, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants